Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MIRI pin #1828

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Update MIRI pin #1828

merged 2 commits into from
Jun 9, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Jun 9, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

The git history does not really indicate why this was pinned, so lets unpin and see what breaks. This is currently blocking #1822

What changes are included in this PR?

Unpins miri version used in CI

Are there any user-facing changes?

No

@tustvold tustvold changed the title Unpin MIRI nightly Update MIRI pin Jun 9, 2022
strategy:
matrix:
arch: [amd64]
rust: [nightly-2022-01-17]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we set this to nightly, would that make it slightly easier to pin again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a one-line change either way so I don't think it really makes all that much difference

@alamb
Copy link
Contributor

alamb commented Jun 9, 2022

If MIRI passes this one looks good to me

@codecov-commenter
Copy link

Codecov Report

Merging #1828 (fb86bad) into master (c92943c) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head fb86bad differs from pull request most recent head e938c3d. Consider uploading reports for the commit e938c3d to get more accurate results

@@           Coverage Diff           @@
##           master    #1828   +/-   ##
=======================================
  Coverage   83.45%   83.45%           
=======================================
  Files         200      200           
  Lines       56719    56719           
=======================================
+ Hits        47334    47336    +2     
+ Misses       9385     9383    -2     
Impacted Files Coverage Δ
parquet/src/encodings/encoding.rs 93.46% <0.00%> (-0.20%) ⬇️
arrow/src/datatypes/datatype.rs 65.79% <0.00%> (+0.37%) ⬆️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c92943c...e938c3d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants