-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MIRI pin #1828
Update MIRI pin #1828
Conversation
f6579c7
to
693ea8b
Compare
5a9230e
to
e938c3d
Compare
strategy: | ||
matrix: | ||
arch: [amd64] | ||
rust: [nightly-2022-01-17] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we set this to nightly
, would that make it slightly easier to pin again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a one-line change either way so I don't think it really makes all that much difference
If MIRI passes this one looks good to me |
Codecov Report
@@ Coverage Diff @@
## master #1828 +/- ##
=======================================
Coverage 83.45% 83.45%
=======================================
Files 200 200
Lines 56719 56719
=======================================
+ Hits 47334 47336 +2
+ Misses 9385 9383 -2
Continue to review full report at Codecov.
|
Which issue does this PR close?
Closes #.
Rationale for this change
The git history does not really indicate why this was pinned, so lets unpin and see what breaks. This is currently blocking #1822
What changes are included in this PR?
Unpins miri version used in CI
Are there any user-facing changes?
No