-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyArrow integration test for C Stream Interface #1848
Conversation
cc @sunchao |
unsafe { | ||
match (*out).release { | ||
None => (), | ||
Some(release) => release(out), | ||
}; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For get_schema
and get_next
, we did it wrongly to releasing the output struct. It should be handled by the caller.
Codecov Report
@@ Coverage Diff @@
## master #1848 +/- ##
==========================================
- Coverage 83.48% 83.46% -0.03%
==========================================
Files 201 201
Lines 56838 56852 +14
==========================================
- Hits 47452 47450 -2
- Misses 9386 9402 +16
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @viirya !
Thanks @sunchao ! |
Which issue does this PR close?
Closes #1847.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?