Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: clarify docstring on DictionaryArray::lookup_key #1910

merged 2 commits into from Jun 21, 2022


Copy link

@alamb alamb commented Jun 19, 2022

While working on something else I found another docstring I think could be improved

@alamb alamb added the documentation Improvements or additions to documentation label Jun 19, 2022
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jun 19, 2022
Copy link

@HaoYang670 HaoYang670 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Copy link

Codecov Report

Merging #1910 (c46d88e) into master (ded6316) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1910      +/-   ##
- Coverage   83.41%   83.41%   -0.01%     
  Files         214      214              
  Lines       56991    56991              
- Hits        47541    47539       -2     
- Misses       9450     9452       +2     
Impacted Files Coverage Δ
arrow/src/array/ 91.91% <ø> (ø)
parquet_derive/src/ 65.53% <0.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ded6316...c46d88e. Read the comment docs.

Co-authored-by: Liang-Chi Hsieh <>
@alamb alamb merged commit aee2628 into apache:master Jun 21, 2022
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
arrow Changes to the arrow crate documentation Improvements or additions to documentation
None yet

Successfully merging this pull request may close these issues.

None yet

5 participants