Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compute): Support doy (day of year) for temporal #2067

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

ovr
Copy link
Contributor

@ovr ovr commented Jul 14, 2022

Rationale for this change

DataFusion uses temporal to operate with date like structures. I want to implement EXTRACT(DOY from NOW()).

What changes are included in this PR?

Implementation of temporal::doy

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2067 (92b1aca) into master (4444cb7) will decrease coverage by 0.00%.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##           master    #2067      +/-   ##
==========================================
- Coverage   83.57%   83.56%   -0.01%     
==========================================
  Files         222      222              
  Lines       58244    58264      +20     
==========================================
+ Hits        48675    48690      +15     
- Misses       9569     9574       +5     
Impacted Files Coverage Δ
arrow/src/compute/kernels/temporal.rs 94.10% <76.19%> (-0.89%) ⬇️
parquet/src/encodings/encoding.rs 93.43% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4444cb7...92b1aca. Read the comment docs.

Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
@tustvold tustvold merged commit 6a37d9f into apache:master Jul 18, 2022
@ursabot
Copy link

ursabot commented Jul 18, 2022

Benchmark runs are scheduled for baseline = 7b3d062 and contender = 6a37d9f. 6a37d9f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ovr ovr deleted the temporal-doy branch July 19, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants