Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows CI (#2069) #2070

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Fix windows CI (#2069) #2070

merged 1 commit into from
Jul 16, 2022

Conversation

tustvold
Copy link
Contributor

Which issue does this PR close?

Closes #2069

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@tustvold
Copy link
Contributor Author

Seems to have magically sorted itself out...

@tustvold tustvold closed this Jul 14, 2022
@tustvold tustvold reopened this Jul 16, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2022

Codecov Report

Merging #2070 (6cebe4e) into master (ca5fe7d) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2070      +/-   ##
==========================================
+ Coverage   83.54%   83.70%   +0.16%     
==========================================
  Files         222      224       +2     
  Lines       58186    58967     +781     
==========================================
+ Hits        48612    49360     +748     
- Misses       9574     9607      +33     
Impacted Files Coverage Δ
parquet/src/file/serialized_reader.rs 93.58% <0.00%> (-1.76%) ⬇️
arrow/src/datatypes/datatype.rs 64.05% <0.00%> (-1.26%) ⬇️
parquet/src/file/metadata.rs 94.70% <0.00%> (-0.69%) ⬇️
arrow/src/array/builder/primitive_builder.rs 92.57% <0.00%> (-0.55%) ⬇️
arrow/src/array/array_decimal.rs 90.59% <0.00%> (-0.53%) ⬇️
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.23%) ⬇️
arrow/src/array/mod.rs 100.00% <0.00%> (ø)
arrow/src/datatypes/mod.rs 99.24% <0.00%> (ø)
arrow/src/util/bit_mask.rs 100.00% <0.00%> (ø)
parquet/src/arrow/record_reader/mod.rs 89.17% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca5fe7d...6cebe4e. Read the comment docs.

@tustvold
Copy link
Contributor Author

I'm not 100% sure this solves the problem, but it appears to at least help so...

@tustvold tustvold requested a review from viirya July 16, 2022 18:25
@tustvold tustvold merged commit 1738a90 into apache:master Jul 16, 2022
@ursabot
Copy link

ursabot commented Jul 16, 2022

Benchmark runs are scheduled for baseline = 54e9181 and contender = 1738a90. 1738a90 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows CI Failing
4 participants