-
Notifications
You must be signed in to change notification settings - Fork 846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docstrings + examples for as_primitive_array
cast functions
#2114
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2114 +/- ##
==========================================
- Coverage 83.71% 83.71% -0.01%
==========================================
Files 225 225
Lines 59563 59567 +4
==========================================
+ Hits 49862 49864 +2
- Misses 9701 9703 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. |
Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
as_primitive_array
etcas_primitive_array
cast functions
Merging as clippy failure unrelated to this PR |
Benchmark runs are scheduled for baseline = db91031 and contender = f62f26a. f62f26a is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
N/A
Rationale for this change
I still see people use the more verbose
as_any().downcast_ref::<Type>().unwrap
code; I also used this frequently in my early arrow days, so I though highlighting and improving the docs for the convenience typecasts might helpWhat changes are included in this PR?
Add some docstrings and examples
Are there any user-facing changes?
More docs