Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fmt + Mac CI jobs #2287

Merged
merged 3 commits into from Aug 2, 2022
Merged

Fix fmt + Mac CI jobs #2287

merged 3 commits into from Aug 2, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Aug 2, 2022

Which issue does this PR close?

Relates to #2279

Rationale for this change

The windows, Mac, fmt and codecov CI checks are broken currently

What changes are included in this PR?

Fix Mac, and fmt CI checks

I am still working on Windows and Coverage (see my flailing attempts at #2280) but I think it is important to restore the CI checks sooner rather than later

Are there any user-facing changes?

No

@alamb alamb changed the title Fix Coverage/Mac CI Fix fmt/Coverage/Mac CI jobs Aug 2, 2022
@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 2, 2022
.github/workflows/rust.yml Outdated Show resolved Hide resolved
@alamb
Copy link
Contributor Author

alamb commented Aug 2, 2022

This is a strange error: https://github.com/apache/arrow-rs/runs/7639063643?check_suite_focus=true

If it passes on rerun I'll file a ticket

thread 'aws::tests::s3_test' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: Other, error: HttpDispatch(HttpDispatchError { message: "Missing information for upload part 2" }) }', object_store/src/aws.rs:1277:59

Updated filed #2288

@alamb alamb changed the title Fix fmt/Coverage/Mac CI jobs Fix fmt + Mac CI jobs Aug 2, 2022
@alamb alamb added the development-process Related to development process of arrow-rs label Aug 2, 2022
@alamb
Copy link
Contributor Author

alamb commented Aug 2, 2022

I am merging this one in because I think it is non controversial and I want to get CI coverage back up. I am happy to make any changes requested in a follow on PR

@alamb alamb merged commit 6b2c757 into apache:master Aug 2, 2022
@alamb alamb deleted the alamb/partial_fix_ci branch August 2, 2022 20:17
@ursabot
Copy link

ursabot commented Aug 2, 2022

Benchmark runs are scheduled for baseline = 3e17891 and contender = 6b2c757. 6b2c757 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants