Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fmt + Mac CI jobs #2287

Merged
merged 3 commits into from Aug 2, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
74 changes: 45 additions & 29 deletions .github/workflows/rust.yml
Expand Up @@ -28,33 +28,56 @@ on:
jobs:

# Check workspace wide compile and test with default features for
# mac and windows
windows-and-macos:
name: Test on ${{ matrix.os }} Rust ${{ matrix.rust }}
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ windows-latest, macos-latest ]
rust: [ stable ]
# mac
macos:
name: Test on Mac
runs-on: macos-latest
steps:
- uses: actions/checkout@v2
with:
submodules: true
- name: Install protoc with brew
run: |
brew install protobuf
- name: Setup Rust toolchain
run: |
rustup toolchain install ${{ matrix.rust }} --no-self-update
rustup default ${{ matrix.rust }}
- name: Install Protoc
uses: arduino/setup-protoc@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
rustup toolchain install stable --no-self-update
rustup default stable
- name: Run tests
shell: bash
run: |
# do not produce debug symbols to keep memory usage down
export RUSTFLAGS="-C debuginfo=0"
cargo test

# Commented out while fixed in https://github.com/apache/arrow-rs/issues/2279
#
# # Check workspace wide compile and test with default features for
# # windows
# windows:
# name: Test on Windows
# runs-on: windows-latest
# steps:
# - uses: actions/checkout@v2
# with:
# submodules: true
# - name: Install protoc with NuGet
# run: |
# nuget.exe install Google.Protobuf -Version 3.21.4 -OutputDirectory d:\\proto
# nuget.exe install Grpc.Tools -Version 2.47.0 -OutputDirectory d:\\proto
# - name: Setup Rust toolchain
# run: |
# rustup toolchain install stable --no-self-update
# rustup default stable
# - name: Run tests
# shell: bash
# run: |
# # do not produce debug symbols to keep memory usage down
# export RUSTFLAGS="-C debuginfo=0"
# # This is where protoc is installed
# export PATH=$PATH:/d/proto/Grpc.Tools.2.47.0/tools/windows_x86
# cargo test


# Run cargo fmt for all crates
lint:
Expand All @@ -75,27 +98,20 @@ jobs:
coverage:
name: Coverage
runs-on: ubuntu-latest
strategy:
matrix:
arch: [ amd64 ]
rust: [ stable ]
container:
alamb marked this conversation as resolved.
Show resolved Hide resolved
image: amd64/rust
env:
# Disable full debug symbol generation to speed up CI build and keep memory down
# "1" means line tables only, which is useful for panic tracebacks.
RUSTFLAGS: "-C debuginfo=1"
steps:
- uses: actions/checkout@v2
with:
submodules: true
- name: Setup Rust toolchain
run: |
rustup toolchain install ${{ matrix.rust }}
rustup default ${{ matrix.rust }}
- name: Install Protoc
uses: arduino/setup-protoc@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
- name: Cache Cargo
uses: actions/cache@v3
uses: ./.github/actions/setup-builder
with:
path: /home/runner/.cargo
key: cargo-coverage-cache3-
rust-version: stable
- name: Run coverage
run: |
rustup toolchain install stable
Expand Down