Simplify shift kernel using new_null_array #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
==========================================
+ Coverage 82.49% 82.60% +0.10%
==========================================
Files 162 162
Lines 43980 44167 +187
==========================================
+ Hits 36282 36483 +201
+ Misses 7698 7684 -14 ☔ View full report in Codecov by Sentry. |
Dandandan
changed the title
alamb
pushed a commit
that referenced
this pull request
Jun 4, 2021
Co-authored-by: Daniel Heres <danielheres@MBP-van-Olaf.home>
alamb
added a commit
that referenced
this pull request
Jun 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #371
Rationale for this change
Code simplification
What changes are included in this PR?
Use
new_null_arrayAre there any user-facing changes?
No