Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use prettier to auto format md files #398

Merged
merged 1 commit into from
Jun 5, 2021
Merged

Conversation

jimexist
Copy link
Member

@jimexist jimexist commented Jun 4, 2021

Which issue does this PR close?

Closes #399.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@jimexist jimexist changed the title use prettiery to auto format md files use prettier to auto format md files Jun 4, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #398 (5874243) into master (45acc62) will not change coverage.
The diff coverage is n/a.

❗ Current head 5874243 differs from pull request most recent head 8f3d0cb. Consider uploading reports for the commit 8f3d0cb to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   82.63%   82.63%           
=======================================
  Files         162      162           
  Lines       44310    44310           
=======================================
  Hits        36617    36617           
  Misses       7693     7693           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45acc62...8f3d0cb. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- what do you think @jorgecarleitao / @nevi-me ?

Copy link
Member

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it :)

@nevi-me nevi-me merged commit 2ddc717 into apache:master Jun 5, 2021
@jimexist jimexist deleted the format-md branch June 5, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use prettier and github action to normalize markdown document syntax
5 participants