Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by float lists #420

Merged
merged 1 commit into from
Jun 8, 2021
Merged

Sort by float lists #420

merged 1 commit into from
Jun 8, 2021

Conversation

medwards
Copy link
Contributor

@medwards medwards commented Jun 7, 2021

Closes #427

Rationale for this change

No particular reason float types shouldn't have the same support as integers in this case. Booleans are excluded due to not being primitive types.

Note: We don't have any use-cases that would need this so its just a completionist nit so feel free to leave in draft.

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2021

Codecov Report

Attention: Patch coverage is 94.44444% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.63%. Comparing base (ddc8a36) to head (acbe83a).
Report is 2931 commits behind head on master.

Files with missing lines Patch % Lines
arrow/src/compute/kernels/sort.rs 94.44% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
+ Coverage   82.62%   82.63%   +0.01%     
==========================================
  Files         162      162              
  Lines       44479    44515      +36     
==========================================
+ Hits        36750    36786      +36     
  Misses       7729     7729              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb
Copy link
Contributor

alamb commented Jun 8, 2021

Thank you for the contribution @medwards 👍

@alamb alamb merged commit b440642 into apache:master Jun 8, 2021
alamb pushed a commit that referenced this pull request Jun 8, 2021
alamb added a commit that referenced this pull request Jun 9, 2021
Co-authored-by: Michael Edwards <medwards@walledcity.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement sort by float lists
4 participants