Reenable MIRI check on PRs #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Second successful run: https://github.com/apache/arrow-rs/pull/421/checks?check_run_id=2766161179 |
alamb
force-pushed
the
alamb/re-enable-miri
branch
from
984a88a
to
503efb9
Compare
|
Fourth success: https://github.com/apache/arrow-rs/pull/421/checks?check_run_id=2778308761 I am merging this one in :) |
This was referenced Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Fixes: #345
Rationale:
We disabled this check in #360 as it was failing intermittently. However, @roee88 diagnosed the problem with a few tests that consumed a lot of memory, and @jhorstmann has been fixing some other MIR related issues in #416
Changes:
bit_length_test_stringandbit_length_test_large_stringto not run under MIRI