object_store: Implement ObjectStore for Arc
#4502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
Jul 10, 2023
object_store/src/lib.rs
Outdated
| @@ -527,7 +527,10 @@ pub trait ObjectStore: std::fmt::Display + Send + Sync + Debug + 'static { | |||
| } | |||
|
|
|||
| #[async_trait] | |||
| impl ObjectStore for Box<dyn ObjectStore> { | |||
| impl<T> ObjectStore for T | |||
There was a problem hiding this comment.
What do you think of using a macro instead of a generic. As Rust lacks specialization support blanket implementations such as this have an annoying habit of causing annoying conflicts down the line?
There was a problem hiding this comment.
I guess that would avoid the potential conflicts with the tradeoff of not working for custom object store wrapper implementations. Let me know which way you prefer :)
There was a problem hiding this comment.
I think I would prefer the macro approach, less chance of unintended consequences
tustvold
approved these changes
Jul 10, 2023
Turbo87
added a commit
to Turbo87/crates.io
that referenced
this pull request
Jul 11, 2023
This can be removed once apache/arrow-rs#4502 is released.
Turbo87
added a commit
to Turbo87/crates.io
that referenced
this pull request
Jul 11, 2023
This can be removed once apache/arrow-rs#4502 is released.
Turbo87
added a commit
to Turbo87/crates.io
that referenced
this pull request
Jul 11, 2023
This can be removed once apache/arrow-rs#4502 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Addresses #4497 (comment)
Rationale for this change
In some situations it can be useful to have multiple instances of e.g. the
InMemorystore, sharing the same backing data. This can be achieved by putting the store in anArc, but until now theObjectStoretrait was only implemented for theBoxstruct.What changes are included in this PR?
This PR changes the
ObjectStore for Boximplementation to be generic over anything that implementsAsRef<dyn ObjectStore>which coversBoxandArc, and potentially any user-implemented wrappers.Are there any user-facing changes?
This could potentially be a breaking change for users that have an
ObjectStoreimplementation on a custom struct which also implementsAsRefsince the compiler might now see two conflicting implementations./cc @tustvold