-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unvendor Archery #459
Unvendor Archery #459
Conversation
@@ -49,78 +49,6 @@ jobs: | |||
--event-name ${{ github.event_name }} \ | |||
--event-payload ${{ github.event_path }} | |||
|
|||
autotune: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this is useful for the rust implementation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree -- I didn't even know it was there lol
- name: Set up Python | ||
uses: actions/setup-python@v2 | ||
with: | ||
python-version: 3.8 | ||
- name: Install Archery and Crossbow dependencies | ||
run: pip install -e arrow/dev/archery[bot] | ||
run: pip install -e dev/archery[bot] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping the comment bot for the time being.
CHANGELOG.md | ||
dev/requirements*.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files only exist in the arrow
repository.
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
=======================================
Coverage 82.64% 82.64%
=======================================
Files 164 164
Lines 45508 45508
=======================================
+ Hits 37608 37609 +1
+ Misses 7900 7899 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the integration tests: https://github.com/apache/arrow-rs/pull/459/checks?check_run_id=2827970303
and the RAT: https://github.com/apache/arrow-rs/runs/2827970245?check_suite_focus=true
Looks like it is working well to me 👍
Thank you @kszucs
@@ -49,78 +49,6 @@ jobs: | |||
--event-name ${{ github.event_name }} \ | |||
--event-payload ${{ github.event_path }} | |||
|
|||
autotune: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree -- I didn't even know it was there lol
name: Lint C++, Python, R, Rust, Docker, RAT | ||
|
||
rat: | ||
name: Release Audit Tool (RAT) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today I learned: "RAT" = "Release Audit Tool" 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you!
maybe we can do the same to datafusion repo? |
Sounds like a good idea to me |
Seems like there is plenty of stuff which we could remove from |
Which issue does this PR close?
Closes #.
Rationale for this change
Instead of vendoring Archery to the
arrow-rs
repository we should rather clonearrow
and install it from there so future updates will be available downstream.What changes are included in this PR?
Are there any user-facing changes?