Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR labeler #468

Merged
merged 10 commits into from
Jun 20, 2021
Merged

Fix PR labeler #468

merged 10 commits into from
Jun 20, 2021

Conversation

Dandandan
Copy link
Contributor

Which issue does this PR close?

Closes #462

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@Dandandan Dandandan marked this pull request as draft June 19, 2021 12:23
@Dandandan Dandandan marked this pull request as ready for review June 19, 2021 12:46
@Dandandan
Copy link
Contributor Author

@alamb this should be merged to master to be able to test the change.

@codecov-commenter
Copy link

codecov-commenter commented Jun 19, 2021

Codecov Report

Merging #468 (d9ddb2f) into master (1f1c637) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   82.65%   82.66%           
=======================================
  Files         165      165           
  Lines       45563    45550   -13     
=======================================
- Hits        37662    37654    -8     
+ Misses       7901     7896    -5     
Impacted Files Coverage Δ
arrow/src/ipc/reader.rs 84.30% <0.00%> (-0.04%) ⬇️
parquet/src/record/api.rs 92.48% <0.00%> (-0.03%) ⬇️
arrow/src/ffi.rs 82.85% <0.00%> (ø)
arrow/src/array/ord.rs 63.33% <0.00%> (ø)
arrow/src/compute/kernels/sort.rs 94.15% <0.00%> (ø)
parquet/src/encodings/decoding.rs 92.47% <0.00%> (ø)
arrow/src/json/reader.rs 84.02% <0.00%> (+0.11%) ⬆️
parquet/src/arrow/array_reader.rs 77.45% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1c637...d9ddb2f. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dandandan I pushed this change to my fork and made a PR there: alamb#12 looks good 👍

Screen Shot 2021-06-20 at 6 59 19 AM

@alamb
Copy link
Contributor

alamb commented Jun 20, 2021

Thank you very much @Dandandan

@alamb alamb merged commit 87ae61d into apache:master Jun 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull Request Labeler is not working
3 participants