Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parquet: Read field IDs from Parquet Schema #4878

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

Samrose-Ahmed
Copy link
Contributor

Currently, field ids are only read from the serialized arrow schema and not the actual parquet file. This PR adds reading the field ids from a Parquet file that doesnt contain the serialized arrow schema.

Which issue does this PR close?

Closes #4877.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Currently, field ids are only read from the serialized arrow schema
and not the actual parquet file. This PR adds reading the field ids
from a Parquet file that doesnt contain the serialized arrow schema.

Signed-off-by: 🐼 Samrose Ahmed 🐼 <samroseahmed@gmail.com>
@github-actions github-actions bot added the parquet Changes to the parquet crate label Sep 29, 2023
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @Samrose-Ahmed

@tustvold tustvold merged commit 8c495b6 into apache:master Oct 1, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parquet: Field Ids are not read from a Parquet file without serialized arrow schema
3 participants