feat: document & streamline flight SQL CLI #4912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
crepererum
force-pushed
the
crepererum/flight_client_log_docs
branch
from
1f24245
to
24bd618
Compare
- add docs to README - add a few more clap features - document arguments - unify key-value parsing for headers and parameters
crepererum
force-pushed
the
crepererum/flight_client_log_docs
branch
from
24bd618
to
48fa79d
Compare
alamb
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
I tried out the instructions and ran this against IOx internally. Very nice 👌 thank you @crepererum
| headers: Vec<KeyValue<String, String>>, | ||
| /// Can be given multiple times. Headers and values are separated by '='. | ||
| /// | ||
| /// Example: `-H foo=bar -H baz=42` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
-
Rationale for this change
Make flight SQL CLI usable by more people.
What changes are included in this PR?
Are there any user-facing changes?
Yep, it's all better.