special case concatenating single element array shortcut #492
Conversation
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
=======================================
Coverage 82.65% 82.65%
=======================================
Files 165 165
Lines 45524 45536 +12
=======================================
+ Hits 37628 37640 +12
Misses 7896 7896
Continue to review full report at Codecov.
|
| @@ -57,6 +57,9 @@ pub fn concat(arrays: &[&Array]) -> Result<ArrayRef> { | |||
| return Err(ArrowError::ComputeError( | |||
| "concat requires input of at least one array".to_string(), | |||
| )); | |||
| } else if arrays.len() == 1 { | |||
| let array = arrays[0]; | |||
| return Ok(array.slice(0, array.len())); | |||
There was a problem hiding this comment.
You might be able to do something like Ok(Array.clone()) instead?
There was a problem hiding this comment.
sadly Array isn't cloneable
There was a problem hiding this comment.
if the param were passing in as ArrayRef then it's possible but it's just pure ref.
There was a problem hiding this comment.
fwiw, this is because if it was clonable, it could not be a trait object. .slice(0, array.len()) is fine imo.
alamb
changed the title
Which issue does this PR close?
concatenating single element array shortcut
Closes #.
Rationale for this change
no need to any work when the given array is single element
What changes are included in this PR?
Are there any user-facing changes?