Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up README.md in advance of the 5.0 release #536

Merged
merged 7 commits into from
Jul 13, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Jul 10, 2021

Which issue does this PR close?

Fixes #463

You can see the rendered versions of this markdown in: https://github.com/alamb/arrow-rs/tree/alamb/update_readmes

Rationale for this change

The READMEs needed some TLC and had intermixed user facing and contributor facing content

What changes are included in this PR?

  1. Since README.md content appears in crates.io (e.g. the arrow page, move all contributing content to CONTRIBUTING.md to mirror the main arrow repo

  2. Update the README.md content to be focused on the "explain to a casual user what this crate is and how to use it"

Are there any user-facing changes?

(Hopefully) better docs!

@github-actions github-actions bot added arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate parquet Changes to the parquet crate labels Jul 10, 2021
@@ -57,125 +56,3 @@ cargo run --example builders
cargo run --example dynamic_types
cargo run --example read_csv
```

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to contributing

@codecov-commenter
Copy link

Codecov Report

Merging #536 (969af49) into master (f1fb2b1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   82.60%   82.60%           
=======================================
  Files         167      167           
  Lines       45984    45984           
=======================================
  Hits        37984    37984           
  Misses       8000     8000           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1fb2b1...969af49. Read the comment docs.

@@ -17,61 +17,122 @@
under the License.
-->

# How to contribute to Apache Arrow
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was still a copy of the main arrow repo's contributing guidelines. I have replaced the content.

It might be worth spending some time breaking out the contributing guide from the developer guide but perhaps we can do that as a follow on PR. At least after this PR the content is no longer inaccurate / refers to JIRA, etc

@alamb
Copy link
Contributor Author

alamb commented Jul 12, 2021

Unless anyone objects, I plan to merge this in tomorrow, and possibly will try and split out developer specific stuff from more general contributing guidelines

@alamb alamb merged commit 6698eed into apache:master Jul 13, 2021
@alamb alamb added the documentation Improvements or additions to documentation label Jul 13, 2021
@roee88 roee88 mentioned this pull request Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate arrow-flight Changes to the arrow-flight crate documentation Improvements or additions to documentation parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve arrow's crate's readme on crates.io
2 participants