Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use DateTime<Utc> for arrow_array::temporal_conversion::as_datetime #5684

Closed
wants to merge 7 commits into from
Closed

use DateTime<Utc> for arrow_array::temporal_conversion::as_datetime #5684

wants to merge 7 commits into from

Commits on Jul 30, 2024

  1. feat(arrow-array): migrate date32_to_datetime and date64_to_datetime … 

    …to use DateTime<Utc>
    @Michael-J-Ward
    Michael-J-Ward committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    502b6fd View commit details
    Browse the repository at this point in the history

  2. feat(arrow-array): migrate timestamp_s_to_datetime to use DateTime<Utc>

    @Michael-J-Ward
    Michael-J-Ward committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2327127 View commit details
    Browse the repository at this point in the history

  3. feat(arrow-array): migrate timestamp_ms_to_datetime to use DateTime<Utc>

    @Michael-J-Ward
    Michael-J-Ward committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    bcfcf62 View commit details
    Browse the repository at this point in the history

  4. feat(arrow-array): migrate timestamp_us_to_datetime to use DateTime<Utc>

    @Michael-J-Ward
    Michael-J-Ward committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d9dfad2 View commit details
    Browse the repository at this point in the history

  5. feat(arrow-array): migrate timestamp_ns_to_datetime to use DateTime<Utc>

    @Michael-J-Ward
    Michael-J-Ward committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0f02ce2 View commit details
    Browse the repository at this point in the history

  6. docs(arrow-array): correct documentation links to point towards Naive… 

    …Time
    @Michael-J-Ward
    Michael-J-Ward committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    28e1e4f View commit details
    Browse the repository at this point in the history

  7. feat(arrow-array): migrate as_datetime to use DateTime<Utc> 

    Any test call-site is updated for DateTime<Utc>.

However, normal code  call-sites immediately convert back to naive datetime.

I'm currently uncertain about the post-migration apis of the following:

- [`arrow_cast::cast::adjust_timestamp_to_timezone`]
- [`arrow_array::array::`PrimitivieArray<t>::value_as_datetime`]
- [`arrow_array::types::ArrowTimestampTime::make_value`]
    @Michael-J-Ward
    Michael-J-Ward committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d5e3c49 View commit details
    Browse the repository at this point in the history