Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single test thread when running miri #891

Closed
wants to merge 2 commits into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 31, 2021

Which issue does this PR close?

Testing to see if this closes #879

Theory is that something about the new version of MIRI uses more memory

Rationale for this change

MIRI is failing on master for reasons that are not reproducible (yet) locally for myself or @jimexist

What changes are included in this PR?

add --test-threads=1 command

Are there any user-facing changes?

No

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2021

Codecov Report

Merging #891 (4645628) into master (898924f) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
- Coverage   82.45%   82.44%   -0.01%     
==========================================
  Files         168      168              
  Lines       48231    48231              
==========================================
- Hits        39767    39765       -2     
- Misses       8464     8466       +2     
Impacted Files Coverage Δ
arrow/src/datatypes/datatype.rs 65.36% <0.00%> (-0.44%) ⬇️
parquet_derive/src/parquet_field.rs 66.59% <0.00%> (-0.23%) ⬇️
parquet/src/arrow/array_reader.rs 77.72% <0.00%> (-0.09%) ⬇️
parquet/src/encodings/encoding.rs 94.67% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898924f...4645628. Read the comment docs.

@alamb
Copy link
Contributor Author

alamb commented Oct 31, 2021

Single thread did not seem to help but skipping the cache did https://github.com/apache/arrow-rs/runs/4059773777?check_suite_focus=true

I'll open a new PR with just the right change

@alamb alamb closed this Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIRI check is failing on master
2 participants