-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor regexp_is_match_utf8_scalar
to try to mitigate miri failures
#895
Conversation
076cd51
to
b1a10e0
Compare
Codecov Report
@@ Coverage Diff @@
## master #895 +/- ##
==========================================
- Coverage 82.30% 82.30% -0.01%
==========================================
Files 168 168
Lines 48031 48031
==========================================
- Hits 39533 39532 -1
- Misses 8498 8499 +1
Continue to review full report at Codecov.
|
regexp_is_match_utf8_scalar
to try to mitigate miri failures
@@ -597,14 +595,15 @@ pub fn regexp_is_match_utf8_scalar<OffsetSize: StringOffsetSizeTrait>( | |||
} | |||
} | |||
|
|||
let buffer = result.finish(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if moving this out would help but let me try this anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a reasonable code change to me, though I don't think MIRI is failing anymore on master, is it?
https://github.com/apache/arrow-rs/runs/4064195444?check_suite_focus=true
I did a retry so not sure why it was fixed I guess I'll merge this as is and see if it resurfaces |
Which issue does this PR close?
Closes #879
Rationale for this change
refactor regexp_is_match_utf8_scalar to try to mitigate miri failures
What changes are included in this PR?
refactor
regexp_is_match_utf8_scalar
to try to mitigate miri failuresAre there any user-facing changes?