feat(ipc): add support for deserializing messages with nested dictionary fields #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helgikrs
force-pushed
the
ipc-read-nested-dict
branch
from
83eee62
to
4182408
Compare
helgikrs
changed the title
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
=======================================
Coverage 82.29% 82.30%
=======================================
Files 168 168
Lines 48028 48083 +55
=======================================
+ Hits 39527 39577 +50
- Misses 8501 8506 +5
Continue to review full report at Codecov.
|
helgikrs
force-pushed
the
ipc-read-nested-dict
branch
2 times, most recently
from
444e203
to
2f564eb
Compare
helgikrs
force-pushed
the
ipc-read-nested-dict
branch
from
2f564eb
to
c04f543
Compare
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Thanks for the suggestions, applied the both. |
helgikrs
force-pushed
the
ipc-read-nested-dict
branch
from
da9bce6
to
0f35de2
Compare
|
Thanks @helgikrs ! |
alamb
added a commit
that referenced
this pull request
Nov 9, 2021
…ary fields (#923) * feat(ipc): read a message containing nested dictionary fields * Apply suggestions from code review Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * address lints Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
alamb
added a commit
that referenced
this pull request
Nov 9, 2021
…ary fields (#923) (#931) * feat(ipc): read a message containing nested dictionary fields * Apply suggestions from code review Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * address lints Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Co-authored-by: Helgi Kristvin Sigurbjarnarson <helgi@lacework.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #846
What changes are included in this PR?
This change recursively walks the entire schema to pick up all dictionary fields (nested) within other fields. This allows the IPC deserialization to match dictionaries with fields, even if they are not found at the top-level of the schema.