-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ipc): add support for deserializing messages with nested dictionary fields #923
Conversation
83eee62
to
4182408
Compare
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
=======================================
Coverage 82.29% 82.30%
=======================================
Files 168 168
Lines 48028 48083 +55
=======================================
+ Hits 39527 39577 +50
- Misses 8501 8506 +5
Continue to review full report at Codecov.
|
444e203
to
2f564eb
Compare
2f564eb
to
c04f543
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @helgikrs -- this looks very nice. 👍
I left some stylistic comments, but I think this PR is also good to merge as is.
Please let me know what you would like to do
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Thanks for the suggestions, applied the both. |
da9bce6
to
0f35de2
Compare
Thanks @helgikrs ! |
…ary fields (#923) * feat(ipc): read a message containing nested dictionary fields * Apply suggestions from code review Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * address lints Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
…ary fields (#923) (#931) * feat(ipc): read a message containing nested dictionary fields * Apply suggestions from code review Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * address lints Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Co-authored-by: Helgi Kristvin Sigurbjarnarson <helgi@lacework.net>
Which issue does this PR close?
Closes #846
What changes are included in this PR?
This change recursively walks the entire schema to pick up all dictionary fields (nested) within other fields. This allows the IPC deserialization to match dictionaries with fields, even if they are not found at the top-level of the schema.