add checker for appending i128 to decimal builder #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liukun4515
changed the title
alamb
reviewed
Nov 9, 2021
There was a problem hiding this comment.
Thank you very much @liukun4515
If you can please avoid adding a new variant to ArrowError I think this PR is ready to merge.
arrow/src/error.rs
Outdated
| @@ -41,6 +41,7 @@ pub enum ArrowError { | |||
| /// Error during import or export to/from the C Data Interface | |||
| CDataInterface(String), | |||
| DictionaryKeyOverflowError, | |||
| DecimalError(String), | |||
There was a problem hiding this comment.
Adding a new variant to this enum makes the change, strictly speaking, not backwards compatible.
I think we should use InvalidArgumentError rather than adding a new variant in order to be consistent with the rest of the codebase as well as ensure this change is backwards compatible (and can be included in the 6.2.0 release)
There was a problem hiding this comment.
thanks for your comments. I will address this.
There was a problem hiding this comment.
@alamb I have updated this pull request according to your suggestion.
liukun4515
changed the title
alamb
pushed a commit
that referenced
this pull request
Nov 11, 2021
* add check for appending i128 to decimal builder * remove the ArrowError(DecimalError)
alamb
added a commit
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #927
Rationale for this change
the code doesn't check the value of input i128 for the decimalbuilder.
resolve the issue #927
What changes are included in this PR?
Add checker for the
append_valuefunction in theDecimalBuilder.Are there any user-facing changes?
No