-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement take kernel for null arrays #939
Conversation
Codecov Report
@@ Coverage Diff @@
## master #939 +/- ##
=======================================
Coverage 82.34% 82.35%
=======================================
Files 168 168
Lines 48520 48541 +21
=======================================
+ Hits 39955 39976 +21
Misses 8565 8565
Continue to review full report at Codecov.
|
1214341
to
fd227be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @bjchambers -- thank you
} | ||
|
||
#[test] | ||
fn test_null_array_indices_out_of_bounds() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for this test -- I was going to say something about validating bounds of the take indexes but this covers it. 👍
Thanks again @bjchambers |
Which issue does this PR close?
Closes #938 .
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?