implement take kernel for null arrays #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #939 +/- ##
=======================================
Coverage 82.34% 82.35%
=======================================
Files 168 168
Lines 48520 48541 +21
=======================================
+ Hits 39955 39976 +21
Misses 8565 8565
Continue to review full report at Codecov.
|
bjchambers
force-pushed
the
take-null-array
branch
from
1214341
to
fd227be
Compare
alamb
approved these changes
Nov 10, 2021
| } | ||
|
|
||
| #[test] | ||
| fn test_null_array_indices_out_of_bounds() { |
There was a problem hiding this comment.
👍 for this test -- I was going to say something about validating bounds of the take indexes but this covers it. 👍
|
Thanks again @bjchambers |
alamb
pushed a commit
that referenced
this pull request
Nov 11, 2021
alamb
added a commit
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #938 .
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?