-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Pretty Print Support For Fixed Size List #958
Conversation
Not sure if there is a way to automatically accept the linting changes but I went ahead and incorporated the lint changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @brianrackle -- looks great to me.
FYI @matthewmturner
builder.values().append_slice(&[4, 5, 6]).unwrap(); | ||
builder.append(true).unwrap(); | ||
builder.values().append_slice(&[7, 8, 9]).unwrap(); | ||
builder.append(true).unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any chance you can add a NULL here as well (append(false)
) to ensure a null entry is handled properly?
Codecov Report
@@ Coverage Diff @@
## master #958 +/- ##
=======================================
Coverage 82.31% 82.31%
=======================================
Files 168 168
Lines 48719 48719
=======================================
+ Hits 40104 40105 +1
+ Misses 8615 8614 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- thanks @brianrackle !
* Inferring 2. as Float64 for issue #929 * Adding pretty print support for fixed size list array * fixing linting errors * adding null row to test
* Inferring 2. as Float64 for issue #929 * Adding pretty print support for fixed size list array * fixing linting errors * adding null row to test
Which issue does this PR close?
Closes #925
Rationale for this change
See #925