Adding Pretty Print Support For Fixed Size List #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if there is a way to automatically accept the linting changes but I went ahead and incorporated the lint changes |
alamb
reviewed
Nov 20, 2021
There was a problem hiding this comment.
Thank you @brianrackle -- looks great to me.
FYI @matthewmturner
| builder.values().append_slice(&[4, 5, 6]).unwrap(); | ||
| builder.append(true).unwrap(); | ||
| builder.values().append_slice(&[7, 8, 9]).unwrap(); | ||
| builder.append(true).unwrap(); |
There was a problem hiding this comment.
Is there any chance you can add a NULL here as well (append(false)) to ensure a null entry is handled properly?
Codecov Report
@@ Coverage Diff @@
## master #958 +/- ##
=======================================
Coverage 82.31% 82.31%
=======================================
Files 168 168
Lines 48719 48719
=======================================
+ Hits 40104 40105 +1
+ Misses 8615 8614 -1
Continue to review full report at Codecov.
|
alamb
approved these changes
Nov 22, 2021
alamb
pushed a commit
that referenced
this pull request
Nov 22, 2021
* Inferring 2. as Float64 for issue #929 * Adding pretty print support for fixed size list array * fixing linting errors * adding null row to test
alamb
added
the
cherry-picked
alamb
pushed a commit
that referenced
this pull request
Nov 23, 2021
* Inferring 2. as Float64 for issue #929 * Adding pretty print support for fixed size list array * fixing linting errors * adding null row to test
alamb
added a commit
that referenced
this pull request
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #925
Rationale for this change
See #925