Remove unneeded rc feature of serde
#990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
==========================================
- Coverage 82.31% 82.30% -0.01%
==========================================
Files 168 168
Lines 48763 48763
==========================================
- Hits 40139 40135 -4
- Misses 8624 8628 +4
Continue to review full report at Codecov.
|
|
oh hey new clippy just dropped... fun! |
|
CI failure is the rust team's way to let everyone know that a new release is out ;) |
|
Conveniently, someone already fixed clippy :) #992 |
|
I think if you merge apache/master into this branch we should be able to get a clean clippy run |
Fixes apache#989. This feature opts into impls for `Rc` and `Arc`, but none of the data structures that use Serialize/Deserialize actually contain `Rc` or `Arc`s. See: - [Serde docs](https://serde.rs/feature-flags.html#-features-rc) - [PR adding this](apache/arrow#3016)
carols10cents
force-pushed
the
remove-serde-rc-feature
branch
from
6468a9a
to
b400617
Compare
alamb
pushed a commit
that referenced
this pull request
Dec 9, 2021
Fixes #989. This feature opts into impls for `Rc` and `Arc`, but none of the data structures that use Serialize/Deserialize actually contain `Rc` or `Arc`s. See: - [Serde docs](https://serde.rs/feature-flags.html#-features-rc) - [PR adding this](apache/arrow#3016)
alamb
added
the
cherry-picked
alamb
added a commit
that referenced
this pull request
Dec 9, 2021
Fixes #989. This feature opts into impls for `Rc` and `Arc`, but none of the data structures that use Serialize/Deserialize actually contain `Rc` or `Arc`s. See: - [Serde docs](https://serde.rs/feature-flags.html#-features-rc) - [PR adding this](apache/arrow#3016) Co-authored-by: Carol (Nichols || Goulding) <193874+carols10cents@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #989.
This feature opts into impls for
RcandArc, but none of the datastructures that use Serialize/Deserialize actually contain
RcorArcs.See:
Which issue does this PR close?
Closes #989.
Rationale for this change
Compile less code, enable fewer features for crates depending on Arrow. The tests still pass without this feature.
What changes are included in this PR?
Remove a feature enabled.
Are there any user-facing changes?
Projects depending on this crate that accidentally took advantage of feature unification to use the functionality added by
rcmight have to add thercfeature themselves... but that would be a bug in their project.I don't think this is documented anywhere user-facing, and I don't think this qualifies as a breaking change to a public API, but I could be wrong, Cargo feature usage is tricky. Please let me know if I'm missing something!