ARROW-3855: [Rust] Schema/Field/Datatype now have derived serde traits #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
paddyhoran
approved these changes
Nov 28, 2018
sunchao
approved these changes
Nov 28, 2018
carols10cents
added a commit
to integer32llc/arrow-rs
that referenced
this pull request
Dec 2, 2021
Fixes apache#989. This feature opts into impls for `Rc` and `Arc`, but none of the data structures that use Serialize/Deserialize actually contain `Rc` or `Arc`s. See: - [Serde docs](https://serde.rs/feature-flags.html#-features-rc) - [PR adding this](apache/arrow#3016)
carols10cents
added a commit
to integer32llc/arrow-rs
that referenced
this pull request
Dec 3, 2021
Fixes apache#989. This feature opts into impls for `Rc` and `Arc`, but none of the data structures that use Serialize/Deserialize actually contain `Rc` or `Arc`s. See: - [Serde docs](https://serde.rs/feature-flags.html#-features-rc) - [PR adding this](apache/arrow#3016)
alamb
pushed a commit
to apache/arrow-rs
that referenced
this pull request
Dec 3, 2021
Fixes #989. This feature opts into impls for `Rc` and `Arc`, but none of the data structures that use Serialize/Deserialize actually contain `Rc` or `Arc`s. See: - [Serde docs](https://serde.rs/feature-flags.html#-features-rc) - [PR adding this](apache/arrow#3016)
alamb
pushed a commit
to apache/arrow-rs
that referenced
this pull request
Dec 9, 2021
Fixes #989. This feature opts into impls for `Rc` and `Arc`, but none of the data structures that use Serialize/Deserialize actually contain `Rc` or `Arc`s. See: - [Serde docs](https://serde.rs/feature-flags.html#-features-rc) - [PR adding this](apache/arrow#3016)
alamb
added a commit
to apache/arrow-rs
that referenced
this pull request
Dec 9, 2021
Fixes #989. This feature opts into impls for `Rc` and `Arc`, but none of the data structures that use Serialize/Deserialize actually contain `Rc` or `Arc`s. See: - [Serde docs](https://serde.rs/feature-flags.html#-features-rc) - [PR adding this](apache/arrow#3016) Co-authored-by: Carol (Nichols || Goulding) <193874+carols10cents@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Schema,Field,DataTypeserializable using the serde crate. This approach supports serialization to numerous binary and text formats supported by the serde crate.The main benefit is to allow users of the Arrow crate to serialize structs that reference Arrow types (for example, allowing a logical query plan to be serialized and sent over the network).
Note that this does not change the custom JSON serialization that is already in place for serializing in the specific format specified in
format/Metadata.md.