Skip to content

Commit

Permalink
GH-33935: [Go][FlightRPC] Implement Flight SQL extensions (#34039)
Browse files Browse the repository at this point in the history
### Rationale for this change

Bringing the Go implementation of Flight SQL in line with the C++ and Java implementations.

### What changes are included in this PR?

Implementation of Transactions, Save points and more. This includes adding new functions to the Server interface.

### Are these changes tested?
 Yes, by integration testing.

### Are there any user-facing changes?
This is a breaking change as a few methods are simplified to utilize the Client's allocator rather than needing a separate allocator passed in.

* Closes: #33935

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
  • Loading branch information
zeroshade committed Feb 6, 2023
1 parent 9b4c972 commit 2b661ba
Show file tree
Hide file tree
Showing 10 changed files with 3,747 additions and 786 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/go.yml
Expand Up @@ -54,7 +54,7 @@ jobs:
- go: 1.17
staticcheck: v0.2.2
- go: 1.18
staticcheck: latest
staticcheck: v0.3.3
env:
GO: ${{ matrix.go }}
STATICCHECK: ${{ matrix.staticcheck }}
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:
- go: 1.17
staticcheck: v0.2.2
- go: 1.18
staticcheck: latest
staticcheck: v0.3.3
env:
GO: ${{ matrix.go }}
STATICCHECK: ${{ matrix.staticcheck }}
Expand Down Expand Up @@ -157,7 +157,7 @@ jobs:
- go: 1.17
staticcheck: v0.2.2
- go: 1.18
staticcheck: latest
staticcheck: v0.3.3
env:
GO: ${{ matrix.go }}
STATICCHECK: ${{ matrix.staticcheck }}
Expand Down Expand Up @@ -198,7 +198,7 @@ jobs:
- go: 1.17
staticcheck: v0.2.2
- go: 1.18
staticcheck: latest
staticcheck: v0.3.3
steps:
- name: Checkout Arrow
uses: actions/checkout@v3
Expand Down Expand Up @@ -233,7 +233,7 @@ jobs:
- go: 1.17
staticcheck: v0.2.2
- go: 1.18
staticcheck: latest
staticcheck: v0.3.3
steps:
- name: Checkout Arrow
uses: actions/checkout@v3
Expand Down Expand Up @@ -286,7 +286,7 @@ jobs:
- go: 1.17
staticcheck: v0.2.2
- go: 1.18
staticcheck: latest
staticcheck: v0.3.3
env:
ARROW_GO_TESTCGO: "1"
steps:
Expand Down Expand Up @@ -362,7 +362,7 @@ jobs:
cache: true
cache-dependency-path: go/go.sum
- name: Install staticcheck
run: go install honnef.co/go/tools/cmd/staticcheck@latest
run: go install honnef.co/go/tools/cmd/staticcheck@v0.3.3
- name: Build
shell: bash
run: ci/scripts/go_build.sh $(pwd)
Expand Down
2 changes: 1 addition & 1 deletion dev/archery/archery/integration/runner.py
Expand Up @@ -438,7 +438,7 @@ def run_all_tests(with_cpp=True, with_java=True, with_js=True,
Scenario(
"flight_sql:extension",
description="Ensure Flight SQL extensions work as expected.",
skip={"Rust", "Go"}
skip={"Rust"}
),
]

Expand Down

0 comments on commit 2b661ba

Please sign in to comment.