Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go][FlightRPC] Implement Flight SQL extensions (transactions, Substrait support) #33935

Closed
lidavidm opened this issue Jan 30, 2023 · 0 comments · Fixed by #34039
Closed

[Go][FlightRPC] Implement Flight SQL extensions (transactions, Substrait support) #33935

lidavidm opened this issue Jan 30, 2023 · 0 comments · Fixed by #34039
Assignees
@zeroshade
Labels
Component: FlightRPC Component: Go Type: enhancement
Milestone
12.0.0

Comments

@lidavidm
Copy link
Member

Describe the enhancement requested

This was done for C++/Java earlier but Go was not included at the time

Component(s)

FlightRPC, Go
zeroshade added a commit to zeroshade/arrow that referenced this issue Feb 3, 2023
@zeroshade
apacheGH-33935: [Go][FlightRPC] Implement FlightSQL Extensions
f24944c
@github-actions github-actions bot mentioned this issue Feb 3, 2023
Merged
zeroshade added a commit that referenced this issue Feb 6, 2023
@zeroshade
GH-33935: [Go][FlightRPC] Implement Flight SQL extensions (#34039)
2b661ba 
### Rationale for this change

Bringing the Go implementation of Flight SQL in line with the C++ and Java implementations.

### What changes are included in this PR?

Implementation of Transactions, Save points and more. This includes adding new functions to the Server interface.

### Are these changes tested?
 Yes, by integration testing.

### Are there any user-facing changes?
This is a breaking change as a few methods are simplified to utilize the Client's allocator rather than needing a separate allocator passed in.

* Closes: #33935

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
@zeroshade zeroshade added this to the 12.0.0 milestone Feb 6, 2023
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
@zeroshade @sjperkins
apacheGH-33935: [Go][FlightRPC] Implement Flight SQL extensions (apac…
37189db 
…he#34039)

### Rationale for this change

Bringing the Go implementation of Flight SQL in line with the C++ and Java implementations.

### What changes are included in this PR?

Implementation of Transactions, Save points and more. This includes adding new functions to the Server interface.

### Are these changes tested?
 Yes, by integration testing.

### Are there any user-facing changes?
This is a breaking change as a few methods are simplified to utilize the Client's allocator rather than needing a separate allocator passed in.

* Closes: apache#33935

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
@zeroshade
apacheGH-33935: [Go][FlightRPC] Implement Flight SQL extensions (apac…
4882350 
…he#34039)

### Rationale for this change

Bringing the Go implementation of Flight SQL in line with the C++ and Java implementations.

### What changes are included in this PR?

Implementation of Transactions, Save points and more. This includes adding new functions to the Server interface.

### Are these changes tested?
 Yes, by integration testing.

### Are there any user-facing changes?
This is a breaking change as a few methods are simplified to utilize the Client's allocator rather than needing a separate allocator passed in.

* Closes: apache#33935

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@zeroshade @fatemehp
apacheGH-33935: [Go][FlightRPC] Implement Flight SQL extensions (apac…
55e8d1a 
…he#34039)

### Rationale for this change

Bringing the Go implementation of Flight SQL in line with the C++ and Java implementations.

### What changes are included in this PR?

Implementation of Transactions, Save points and more. This includes adding new functions to the Server interface.

### Are these changes tested?
 Yes, by integration testing.

### Are there any user-facing changes?
This is a breaking change as a few methods are simplified to utilize the Client's allocator rather than needing a separate allocator passed in.

* Closes: apache#33935

Authored-by: Matt Topol <zotthewizard@gmail.com>
Signed-off-by: Matt Topol <zotthewizard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeroshade zeroshade

Labels
Component: FlightRPC Component: Go Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-33935: [Go][FlightRPC] Implement Flight SQL extensions zeroshade/arrow
2 participants
@lidavidm @zeroshade