Skip to content

Commit

Permalink
GH-35107: [FlightSQL]: Use uint8 to refer to 8 bit unsigned integer…
Browse files Browse the repository at this point in the history
…s rather than `uint1` (#35108)

### Rationale for this change

The spec is inconsistent -- see details on #35107

### What changes are included in this PR?

Use `uint8` to refer to 8 bit unsigned integers rather than `uint1`

### Are these changes tested?
No, they are comment only changed

### Are there any user-facing changes?

This clarifies a small corner case in the document
* Closes: #35107

Authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
  • Loading branch information
alamb committed Apr 16, 2023
1 parent cc20df1 commit 4328eba
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions format/FlightSql.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1324,8 +1324,8 @@ enum UpdateDeleteRules {
* key_sequence: int not null,
* fk_key_name: utf8,
* pk_key_name: utf8,
* update_rule: uint1 not null,
* delete_rule: uint1 not null
* update_rule: uint8 not null,
* delete_rule: uint8 not null
* >
* The returned data should be ordered by fk_catalog_name, fk_db_schema_name, fk_table_name, fk_key_name, then key_sequence.
* update_rule and delete_rule returns a byte that is equivalent to actions declared on UpdateDeleteRules enum.
Expand Down Expand Up @@ -1370,8 +1370,8 @@ message CommandGetExportedKeys {
* key_sequence: int not null,
* fk_key_name: utf8,
* pk_key_name: utf8,
* update_rule: uint1 not null,
* delete_rule: uint1 not null
* update_rule: uint8 not null,
* delete_rule: uint8 not null
* >
* The returned data should be ordered by pk_catalog_name, pk_db_schema_name, pk_table_name, pk_key_name, then key_sequence.
* update_rule and delete_rule returns a byte that is equivalent to actions:
Expand Down Expand Up @@ -1423,8 +1423,8 @@ message CommandGetImportedKeys {
* key_sequence: int not null,
* fk_key_name: utf8,
* pk_key_name: utf8,
* update_rule: uint1 not null,
* delete_rule: uint1 not null
* update_rule: uint8 not null,
* delete_rule: uint8 not null
* >
* The returned data should be ordered by pk_catalog_name, pk_db_schema_name, pk_table_name, pk_key_name, then key_sequence.
* update_rule and delete_rule returns a byte that is equivalent to actions:
Expand Down

0 comments on commit 4328eba

Please sign in to comment.