-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Format][FlightSQL] Spec refers to "uint1" type (which seems Java specific) rather than "uint8" #35107
Comments
alamb
changed the title
FlightSQL.proto document refers to "uint1" type (which seems Java specific)
FlightSQL.proto document refers to "uint1" type (which seems Java specific) rather than "uint8"
Apr 13, 2023
alamb
changed the title
FlightSQL.proto document refers to "uint1" type (which seems Java specific) rather than "uint8"
[FLIGHTSQL] Spec refers to "uint1" type (which seems Java specific) rather than "uint8"
Apr 13, 2023
alamb
changed the title
[FLIGHTSQL] Spec refers to "uint1" type (which seems Java specific) rather than "uint8"
[Format][FlightSQL] Spec refers to "uint1" type (which seems Java specific) rather than "uint8"
Apr 13, 2023
alamb
added a commit
that referenced
this issue
Apr 16, 2023
…s rather than `uint1` (#35108) ### Rationale for this change The spec is inconsistent -- see details on #35107 ### What changes are included in this PR? Use `uint8` to refer to 8 bit unsigned integers rather than `uint1` ### Are these changes tested? No, they are comment only changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: #35107 Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
liujiacheng777
pushed a commit
to LoongArch-Python/arrow
that referenced
this issue
May 11, 2023
…ntegers rather than `uint1` (apache#35108) ### Rationale for this change The spec is inconsistent -- see details on apache#35107 ### What changes are included in this PR? Use `uint8` to refer to 8 bit unsigned integers rather than `uint1` ### Are these changes tested? No, they are comment only changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35107 Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
ArgusLi
pushed a commit
to Bit-Quill/arrow
that referenced
this issue
May 15, 2023
…ntegers rather than `uint1` (apache#35108) ### Rationale for this change The spec is inconsistent -- see details on apache#35107 ### What changes are included in this PR? Use `uint8` to refer to 8 bit unsigned integers rather than `uint1` ### Are these changes tested? No, they are comment only changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35107 Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
rtpsw
pushed a commit
to rtpsw/arrow
that referenced
this issue
May 16, 2023
…ntegers rather than `uint1` (apache#35108) ### Rationale for this change The spec is inconsistent -- see details on apache#35107 ### What changes are included in this PR? Use `uint8` to refer to 8 bit unsigned integers rather than `uint1` ### Are these changes tested? No, they are comment only changed ### Are there any user-facing changes? This clarifies a small corner case in the document * Closes: apache#35107 Authored-by: Andrew Lamb <andrew@nerdnetworks.org> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug, including details regarding any error messages, version, and platform.
While implement FlightSQL in our project, we found that the FlightSql.proto format reference refers to a type
unit1
(notuint16
oruint8
)arrow/format/FlightSql.proto
Lines 1327 to 1328 in 6432a23
What
uint1
means was slightly unclear as the Arrow spec refers to "Int" types withbitWidth
of 8, 16, 32 or 64 but the rust implementation has UInt8, UInt16, UInt32 and UInt64.arrow/format/Schema.fbs
Lines 145 to 148 in 6432a23
Go uses
uint8
:arrow/go/arrow/flight/flightsql/schema_ref/reference_schemas.go
Line 66 in 6432a23
C++ uses
uint8
:arrow/cpp/src/arrow/flight/sql/server.cc
Line 1145 in 6432a23
Java uses "UINT1"
arrow/java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlProducer.java
Lines 851 to 852 in 6432a23
Reading the Java Arrow implementation, it appears to use the term UINT1 for 8 bit integers:
arrow/java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileReader.java
Lines 368 to 381 in 6432a23
However, inconsistently, while other parts of the flightsql spec refer to uint32
arrow/format/FlightSql.proto
Line 34 in 6432a23
The Java code uses UINT4 for this
arrow/java/flight/flight-sql/src/main/java/org/apache/arrow/flight/sql/FlightSqlProducer.java
Line 874 in 6432a23
Proposal
I propose that we change the proto spec to be consistent and use
uint<bitwidth>
to refer to integer types. So specifically, changeuint1
touint8
to match C++/Rust/Go as well as the convention in the rest of Flight.protoHere is the reference to details of our discussion https://github.com/influxdata/influxdb_iox/pull/7532/files#r1165307397
Component(s)
Format
The text was updated successfully, but these errors were encountered: