Skip to content

Commit

Permalink
ARROW-4961: [C++] Add documentation note that GTest_SOURCE=BUNDLED is…
Browse files Browse the repository at this point in the history
… current required on Windows

Until we figure out why things don't link properly with the conda-forge package we need this

Author: Wes McKinney <wesm+git@apache.org>

Closes #3984 from wesm/ARROW-4961 and squashes the following commits:

538b083 <Wes McKinney> Add note that GTest_SOURCE=BUNDLED is current required on Windows
  • Loading branch information
wesm committed Mar 20, 2019
1 parent fe26c70 commit 8abed59
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions docs/source/developers/cpp.rst
Original file line number Diff line number Diff line change
Expand Up @@ -565,7 +565,7 @@ System Setup
~~~~~~~~~~~~

Microsoft provides the free Visual Studio Community edition. When doing
development in teh the shell, you must initialize the development
development in the the shell, you must initialize the development
environment.

For Visual Studio 2015, execute the following batch script:
Expand Down Expand Up @@ -647,9 +647,17 @@ an out of source build by generating a MSVC solution:
cd cpp
mkdir build
cd build
cmake -G "Visual Studio 14 2015 Win64" ..
cmake .. -G "Visual Studio 14 2015 Win64" ^
-DARROW_BUILD_TESTS=ON ^
-DGTest_SOURCE=BUNDLED
cmake --build . --config Release
.. note::

Currently building the unit tests does not work properly with googletest
from conda-forge, so we must use the ``BUNDLED`` source for building that
dependency

Building with Ninja and clcache
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Expand All @@ -675,7 +683,8 @@ do an out of source build by generating Ninja files:
cd cpp
mkdir build
cd build
cmake -G "Ninja" ..
cmake -G "Ninja" -DARROW_BUILD_TESTS=ON ^
-DGTest_SOURCE=BUNDLED ..
cmake --build . --config Release
Building with NMake
Expand Down

0 comments on commit 8abed59

Please sign in to comment.