Skip to content

Commit

Permalink
GH-38439: [Java][CI] Use Eclipse Temurin for all Java CI linux jobs (#…
Browse files Browse the repository at this point in the history
…38440)

### Rationale for this change

Use the same JDK vendor for all linux CI jobs and upgrade maven to latest version.

### What changes are included in this PR?

* Eclipse Temurin image for Ubuntu is used for JDK 8 and 11
* maven is upgraded to 3.9.5 for all Ubuntu jobs

### Are these changes tested?

This will be tested in CI.

### Are there any user-facing changes?

No, just a developer change when using docker/archery. The image name is now `java` instead of `eclipse-java` and `debian-java`.
* Closes: #38439

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
  • Loading branch information
danepitkin committed Nov 9, 2023
1 parent 75a0403 commit 9569be8
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 41 deletions.
23 changes: 4 additions & 19 deletions .github/workflows/java.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,32 +49,17 @@ env:

jobs:

debian:
name: ${{ matrix.title }}
ubuntu:
name: AMD64 Ubuntu 22.04 Java JDK ${{ matrix.jdk }} Maven ${{ matrix.maven }}
runs-on: ubuntu-latest
if: ${{ !contains(github.event.pull_request.title, 'WIP') }}
timeout-minutes: 30
strategy:
fail-fast: false
matrix:
jdk: [8, 11, 17, 21]
include:
- jdk: 8
title: AMD64 Debian 9 Java JDK 8 Maven 3.5.4
maven: 3.5.4
image: debian-java
- jdk: 11
title: AMD64 Debian 9 Java JDK 11 Maven 3.6.2
maven: 3.6.2
image: debian-java
- jdk: 17
title: AMD64 Ubuntu 22.04 Java JDK 17 Maven 3.9.4
maven: 3.9.4
image: eclipse-java
- jdk: 21
title: AMD64 Ubuntu 22.04 Java JDK 21 Maven 3.9.4
maven: 3.9.4
image: eclipse-java
maven: [3.9.5]
image: [java]
env:
JDK: ${{ matrix.jdk }}
MAVEN: ${{ matrix.maven }}
Expand Down
27 changes: 7 additions & 20 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,10 @@ x-hierarchy:
- debian-go:
- debian-go-cgo
- debian-go-cgo-python
- debian-java
- debian-js
- eclipse-java
- fedora-cpp:
- fedora-python
- java
- python-sdist
- ubuntu-cpp:
- ubuntu-cpp-static
Expand Down Expand Up @@ -1674,14 +1673,14 @@ services:

################################ Java #######################################

debian-java:
java:
# Usage:
# docker-compose build debian-java
# docker-compose run debian-java
# docker-compose build java
# docker-compose run java
# Parameters:
# MAVEN: 3.5.4, 3.6.2
# JDK: 8, 11
image: ${ARCH}/maven:${MAVEN}-jdk-${JDK}
# MAVEN: 3.9.5
# JDK: 8, 11, 17, 21
image: ${ARCH}/maven:${MAVEN}-eclipse-temurin-${JDK}
shm_size: *shm-size
volumes: &java-volumes
- .:/arrow:delegated
Expand All @@ -1691,18 +1690,6 @@ services:
/arrow/ci/scripts/java_build.sh /arrow /build &&
/arrow/ci/scripts/java_test.sh /arrow /build"

eclipse-java:
# Usage:
# docker-compose build eclipse-java
# docker-compose run eclipse-java
# Parameters:
# MAVEN: 3.9.4
# JDK: 17, 21
image: ${ARCH}/maven:${MAVEN}-eclipse-temurin-${JDK}
shm_size: *shm-size
volumes: *java-volumes
command: *java-command

############################## Integration ##################################

conda-integration:
Expand Down
4 changes: 2 additions & 2 deletions docs/source/developers/java/building.rst
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ Docker compose
$ cd arrow/java
$ export JAVA_HOME=<absolute path to your java home>
$ java --version
$ docker-compose run debian-java
$ docker-compose run java
Archery
~~~~~~~
Expand All @@ -86,7 +86,7 @@ Archery
$ cd arrow/java
$ export JAVA_HOME=<absolute path to your java home>
$ java --version
$ archery docker run debian-java
$ archery docker run java
Building JNI Libraries (\*.dylib / \*.so / \*.dll)
--------------------------------------------------
Expand Down

0 comments on commit 9569be8

Please sign in to comment.