Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-38439: [Java][CI] Use Eclipse Temurin for all Java CI linux jobs #38440

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

danepitkin
Copy link
Member

@danepitkin danepitkin commented Oct 24, 2023

Rationale for this change

Use the same JDK vendor for all linux CI jobs and upgrade maven to latest version.

What changes are included in this PR?

  • Eclipse Temurin image for Ubuntu is used for JDK 8 and 11
  • maven is upgraded to 3.9.5 for all Ubuntu jobs

Are these changes tested?

This will be tested in CI.

Are there any user-facing changes?

No, just a developer change when using docker/archery. The image name is now java instead of eclipse-java and debian-java.

@github-actions
Copy link

⚠️ GitHub issue #38439 has been automatically assigned in GitHub to PR creator.

Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, afaik that docker image is only used for PR ci as the only other java jobs are java-jars and verify-rc.

@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Oct 28, 2023
@danepitkin
Copy link
Member Author

Thanks! Should we go ahead and merge this?

@assignUser assignUser merged commit 9569be8 into apache:main Nov 9, 2023
56 of 57 checks passed
@assignUser assignUser removed the awaiting committer review Awaiting committer review label Nov 9, 2023
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9569be8.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

loicalleyne pushed a commit to loicalleyne/arrow that referenced this pull request Nov 13, 2023
…jobs (apache#38440)

### Rationale for this change

Use the same JDK vendor for all linux CI jobs and upgrade maven to latest version.

### What changes are included in this PR?

* Eclipse Temurin image for Ubuntu is used for JDK 8 and 11
* maven is upgraded to 3.9.5 for all Ubuntu jobs

### Are these changes tested?

This will be tested in CI.

### Are there any user-facing changes?

No, just a developer change when using docker/archery. The image name is now `java` instead of `eclipse-java` and `debian-java`.
* Closes: apache#38439

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
dgreiss pushed a commit to dgreiss/arrow that referenced this pull request Feb 19, 2024
…jobs (apache#38440)

### Rationale for this change

Use the same JDK vendor for all linux CI jobs and upgrade maven to latest version.

### What changes are included in this PR?

* Eclipse Temurin image for Ubuntu is used for JDK 8 and 11
* maven is upgraded to 3.9.5 for all Ubuntu jobs

### Are these changes tested?

This will be tested in CI.

### Are there any user-facing changes?

No, just a developer change when using docker/archery. The image name is now `java` instead of `eclipse-java` and `debian-java`.
* Closes: apache#38439

Authored-by: Dane Pitkin <dane@voltrondata.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java][CI] docker compose fails on eclipse temurin image
2 participants