Skip to content

Commit

Permalink
GH-32050: [C++] Implement Rank kernel on chunked arrays (#33846)
Browse files Browse the repository at this point in the history
This is a duplicate/continuation of #14505.

William Ayd did the bulk of the work here. There was a somewhat nontrivial rebase that needed to occur (due to one of my recent PRs) so Will's commits have been squashed with the credits intact.

Besides that, I did some refactoring to avoid duplicating `ChunkedArraySorter`'s logic in `ChunkedArrayRanker`. 

* Closes: #32050

Lead-authored-by: benibus <bpharks@gmx.com>
Co-authored-by: Will Ayd <william.ayd@icloud.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
  • Loading branch information
3 people committed Feb 2, 2023
1 parent 5b705a4 commit a703a07
Show file tree
Hide file tree
Showing 5 changed files with 437 additions and 302 deletions.
3 changes: 2 additions & 1 deletion cpp/src/arrow/compute/kernels/vector_array_sort.cc
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,8 @@ Status ArraySortIndicesChunked(KernelContext* ctx, const ExecBatch& batch, Datum
std::iota(out_begin, out_end, 0);
return SortChunkedArray(ctx->exec_context(), out_begin, out_end,
*batch[0].chunked_array(), options.order,
options.null_placement);
options.null_placement)
.status();
}

template <template <typename...> class ExecTemplate>
Expand Down
Loading

0 comments on commit a703a07

Please sign in to comment.