Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Implement Rank kernel on chunked arrays #32050

Closed
Tracked by #33957
asfimport opened this issue Jun 1, 2022 · 3 comments · Fixed by #33846
Closed
Tracked by #33957

[C++] Implement Rank kernel on chunked arrays #32050

asfimport opened this issue Jun 1, 2022 · 3 comments · Fixed by #33846
Assignees
@benibus
Labels
Component: C++ Type: enhancement
Milestone
12.0.0

Comments

@asfimport
Copy link
Collaborator

In ARROW-16234 the rank kernel was implemented for plain arrays, it should also be implemented for chunked arrays.

Reporter: Antoine Pitrou / @pitrou
Assignee: Will Ayd / @WillAyd

PRs and other links:

Note: This issue was originally created as ARROW-16707. Please see the migration documentation for further details.
@asfimport
Copy link
Collaborator Author

Antoine Pitrou / @pitrou:
cc @WillAyd

@asfimport
Copy link
Collaborator Author

Will Ayd / @WillAyd:
I'll take this one

@asfimport
Copy link
Collaborator Author

Apache Arrow JIRA Bot:
This issue was last updated over 90 days ago, which may be an indication it is no longer being actively worked. To better reflect the current state, the issue is being unassigned per project policy. Please feel free to re-take assignment of the issue if it is being actively worked, or if you plan to start that work soon.

@github-actions github-actions bot mentioned this issue Jan 24, 2023
Merged
@pitrou pitrou mentioned this issue Jan 31, 2023
Closed
1 task
pitrou added a commit that referenced this issue Feb 2, 2023
@benibus @WillAyd @pitrou
GH-32050: [C++] Implement Rank kernel on chunked arrays (#33846)
a703a07 
This is a duplicate/continuation of #14505.

William Ayd did the bulk of the work here. There was a somewhat nontrivial rebase that needed to occur (due to one of my recent PRs) so Will's commits have been squashed with the credits intact.

Besides that, I did some refactoring to avoid duplicating `ChunkedArraySorter`'s logic in `ChunkedArrayRanker`. 

* Closes: #32050

Lead-authored-by: benibus <bpharks@gmx.com>
Co-authored-by: Will Ayd <william.ayd@icloud.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
@pitrou pitrou added this to the 12.0.0 milestone Feb 2, 2023
sjperkins pushed a commit to sjperkins/arrow that referenced this issue Feb 10, 2023
@benibus @WillAyd
@pitrou @sjperkins
apacheGH-32050: [C++] Implement Rank kernel on chunked arrays (apache…
69f715d 
…#33846)

This is a duplicate/continuation of apache#14505.

William Ayd did the bulk of the work here. There was a somewhat nontrivial rebase that needed to occur (due to one of my recent PRs) so Will's commits have been squashed with the credits intact.

Besides that, I did some refactoring to avoid duplicating `ChunkedArraySorter`'s logic in `ChunkedArrayRanker`. 

* Closes: apache#32050

Lead-authored-by: benibus <bpharks@gmx.com>
Co-authored-by: Will Ayd <william.ayd@icloud.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
gringasalpastor pushed a commit to gringasalpastor/arrow that referenced this issue Feb 17, 2023
@benibus @WillAyd @pitrou
apacheGH-32050: [C++] Implement Rank kernel on chunked arrays (apache…
8250651 
…#33846)

This is a duplicate/continuation of apache#14505.

William Ayd did the bulk of the work here. There was a somewhat nontrivial rebase that needed to occur (due to one of my recent PRs) so Will's commits have been squashed with the credits intact.

Besides that, I did some refactoring to avoid duplicating `ChunkedArraySorter`'s logic in `ChunkedArrayRanker`. 

* Closes: apache#32050

Lead-authored-by: benibus <bpharks@gmx.com>
Co-authored-by: Will Ayd <william.ayd@icloud.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
fatemehp pushed a commit to fatemehp/arrow that referenced this issue Feb 24, 2023
@benibus @WillAyd
@pitrou @fatemehp
apacheGH-32050: [C++] Implement Rank kernel on chunked arrays (apache…
6871246 
…#33846)

This is a duplicate/continuation of apache#14505.

William Ayd did the bulk of the work here. There was a somewhat nontrivial rebase that needed to occur (due to one of my recent PRs) so Will's commits have been squashed with the credits intact.

Besides that, I did some refactoring to avoid duplicating `ChunkedArraySorter`'s logic in `ChunkedArrayRanker`. 

* Closes: apache#32050

Lead-authored-by: benibus <bpharks@gmx.com>
Co-authored-by: Will Ayd <william.ayd@icloud.com>
Co-authored-by: Antoine Pitrou <antoine@python.org>
Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benibus benibus

Labels
Component: C++ Type: enhancement
Projects
None yet
Milestone
12.0.0
Development

Successfully merging a pull request may close this issue.

GH-32050: [C++] Implement Rank kernel on chunked arrays benibus/arrow
3 participants
@pitrou @benibus @asfimport