Skip to content

Commit

Permalink
ARROW-17990: [C++] Restore -mbmi2 flag (#14375)
Browse files Browse the repository at this point in the history
#14342 removed -mbmi2 flag accidentally. It should not be removed. If we remove it, a build error is occurred on macOS High Sierra.

https://github.com/ursacomputing/crossbow/actions/runs/3225397138/jobs/5278904264#step:13:7034

    /Users/voltrondata/tmp/hbtmp/apache-arrow-20221011-35535-3alkwv/cpp/src/parquet/level_conversion_inc.h:278:10:
    error: always_inline function '_pext_u64' requires target feature
    'bmi2', but would be inlined into function 'ExtractBits' that is
    compiled without support for 'bmi2'
      return _pext_u64(bitmap, select_bitmap);
             ^

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
  • Loading branch information
kou committed Oct 11, 2022
1 parent aec3584 commit cdd0fdf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cpp/src/parquet/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ if(ARROW_HAVE_RUNTIME_AVX2)
set_source_files_properties(level_conversion_bmi2.cc
PROPERTIES SKIP_PRECOMPILE_HEADERS ON
COMPILE_FLAGS
"${ARROW_AVX2_FLAG} -DARROW_HAVE_BMI2 ${CXX_FLAGS_RELEASE}"
"${ARROW_AVX2_FLAG} -DARROW_HAVE_BMI2 -mbmi2 ${CXX_FLAGS_RELEASE}"
)
endif()

Expand Down

0 comments on commit cdd0fdf

Please sign in to comment.