-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17990: [C++] Restore -mbmi2 flag #14375
Conversation
apache#14342 removed -mbmi2 flag accidentally. It should not be removed. If we remove it, a build error is occurred on macOS High Sierra. https://github.com/ursacomputing/crossbow/actions/runs/3225397138/jobs/5278904264#step:13:7034 /Users/voltrondata/tmp/hbtmp/apache-arrow-20221011-35535-3alkwv/cpp/src/parquet/level_conversion_inc.h:278:10: error: always_inline function '_pext_u64' requires target feature 'bmi2', but would be inlined into function 'ExtractBits' that is compiled without support for 'bmi2' return _pext_u64(bitmap, select_bitmap); ^
@github-actions crossbow submit r-binary-packages |
Revision: fd6e0a4 Submitted crossbow builds: ursacomputing/crossbow @ actions-b7bb90f6eb
|
There is a Jira for this: https://issues.apache.org/jira/browse/ARROW-17990 |
Thanks! I've updated title! |
|
Passed. I merge this. |
Benchmark runs are scheduled for baseline = aec3584 and contender = cdd0fdf. cdd0fdf is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
#14342 removed -mbmi2 flag accidentally. It should not be removed. If we remove it, a build error is occurred on macOS High Sierra.
https://github.com/ursacomputing/crossbow/actions/runs/3225397138/jobs/5278904264#step:13:7034