Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17990: [C++] Restore -mbmi2 flag #14375

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

kou
Copy link
Member

@kou kou commented Oct 11, 2022

#14342 removed -mbmi2 flag accidentally. It should not be removed. If we remove it, a build error is occurred on macOS High Sierra.

https://github.com/ursacomputing/crossbow/actions/runs/3225397138/jobs/5278904264#step:13:7034

/Users/voltrondata/tmp/hbtmp/apache-arrow-20221011-35535-3alkwv/cpp/src/parquet/level_conversion_inc.h:278:10:
error: always_inline function '_pext_u64' requires target feature
'bmi2', but would be inlined into function 'ExtractBits' that is
compiled without support for 'bmi2'
  return _pext_u64(bitmap, select_bitmap);
         ^

apache#14342 removed -mbmi2 flag
accidentally. It should not be removed. If we remove it, a build error
is occurred on macOS High Sierra.

https://github.com/ursacomputing/crossbow/actions/runs/3225397138/jobs/5278904264#step:13:7034

    /Users/voltrondata/tmp/hbtmp/apache-arrow-20221011-35535-3alkwv/cpp/src/parquet/level_conversion_inc.h:278:10:
    error: always_inline function '_pext_u64' requires target feature
    'bmi2', but would be inlined into function 'ExtractBits' that is
    compiled without support for 'bmi2'
      return _pext_u64(bitmap, select_bitmap);
             ^
@kou
Copy link
Member Author

kou commented Oct 11, 2022

@github-actions crossbow submit r-binary-packages

@github-actions
Copy link

@github-actions
Copy link

Revision: fd6e0a4

Submitted crossbow builds: ursacomputing/crossbow @ actions-b7bb90f6eb

Task Status
r-binary-packages Github Actions

@assignUser
Copy link
Member

There is a Jira for this: https://issues.apache.org/jira/browse/ARROW-17990

@kou kou changed the title ARROW-15678: [C++] Restore -mbmi2 flag ARROW-17990: [C++] Restore -mbmi2 flag Oct 11, 2022
@kou
Copy link
Member Author

kou commented Oct 11, 2022

Thanks! I've updated title!

@github-actions
Copy link

@github-actions
Copy link

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@kou
Copy link
Member Author

kou commented Oct 11, 2022

Passed. I merge this.

@kou kou merged commit cdd0fdf into apache:master Oct 11, 2022
@kou kou deleted the cpp-cmake-minsizerel-restore-mbmi2 branch October 11, 2022 21:35
@ursabot
Copy link

ursabot commented Oct 12, 2022

Benchmark runs are scheduled for baseline = aec3584 and contender = cdd0fdf. cdd0fdf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.57% ⬆️0.14%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] cdd0fdf3 ec2-t3-xlarge-us-east-2
[Failed] cdd0fdf3 test-mac-arm
[Failed] cdd0fdf3 ursa-i9-9960x
[Finished] cdd0fdf3 ursa-thinkcentre-m75q
[Finished] aec35844 ec2-t3-xlarge-us-east-2
[Failed] aec35844 test-mac-arm
[Failed] aec35844 ursa-i9-9960x
[Finished] aec35844 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Oct 12, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants