Skip to content

Commit

Permalink
ARROW-17848: [R] Skip lubridate::format_ISO8601 tests until next rele…
Browse files Browse the repository at this point in the history
…ase (#14282)

Code comment explains the story. If all CI passes, this has worked.

Authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
  • Loading branch information
nealrichardson committed Oct 1, 2022
1 parent 2748f3d commit d60d8c6
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion r/tests/testthat/test-dplyr-funcs-datetime.R
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,12 @@ test_that("strftime", {
test_that("format_ISO8601", {
# https://issues.apache.org/jira/projects/ARROW/issues/ARROW-15266
skip_if_not_available("re2")
# A change in R altered the behavior of lubridate::format_ISO8601:
# https://github.com/wch/r-source/commit/f6fd993f8a2f799a56dbecbd8238f155191fc31b
# Fixed in lubridate here:
# https://github.com/tidyverse/lubridate/pull/1068
skip_if_not(packageVersion("lubridate") > "1.8")

times <- tibble(x = c(lubridate::ymd_hms("2018-10-07 19:04:05", tz = "Etc/GMT+6"), NA))

compare_dplyr_binding(
Expand Down Expand Up @@ -3166,9 +3172,12 @@ check_timestamp_rounding <- function(data, unit, lubridate_unit = unit, ...) {

test_that("date round/floor/ceil works for units of 1 day or less", {
test_df %>% check_date_rounding("1 millisecond", lubridate_unit = ".001 second")
test_df %>% check_date_rounding("1 day")
test_df %>% check_date_rounding("1 second")
test_df %>% check_date_rounding("1 hour")

skip("floor_date(as.Date(NA), '1 day') is no longer NA on latest R-devel")
# Possibly https://github.com/wch/r-source/commit/4f70ce0d79eeda7464cf97448e515275cbef754b
test_df %>% check_date_rounding("1 day")
})

test_that("timestamp round/floor/ceil works for units of 1 day or less", {
Expand Down

0 comments on commit d60d8c6

Please sign in to comment.