Skip to content

Commit

Permalink
GH-38861: [C++] Add missing "-framework Security" to Libs.private in …
Browse files Browse the repository at this point in the history
…arrow.pc (#38869)

### Rationale for this change

It's required only when:

* We use bundled aws-sdk-cpp.
* We use static library for Apache Arrow C++.

Because bundled aws-sdk-cpp uses Security framework.

### What changes are included in this PR?

Add `-framework Security` to `Libs.private` only on the condition.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: #38861

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
  • Loading branch information
kou committed Nov 25, 2023
1 parent 7da7895 commit eb5de18
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions cpp/cmake_modules/ThirdpartyToolchain.cmake
Expand Up @@ -5063,6 +5063,9 @@ if(ARROW_S3)
string(APPEND ARROW_PC_REQUIRES_PRIVATE " libcurl")
endif()
string(APPEND ARROW_PC_REQUIRES_PRIVATE " openssl")
if(APPLE)
string(APPEND ARROW_PC_LIBS_PRIVATE " -framework Security")
endif()
endif()
endif()

Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/CMakeLists.txt
Expand Up @@ -598,7 +598,7 @@ if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
IMPORTED_LOCATION)
install(FILES ${arrow_bundled_dependencies_path} ${INSTALL_IS_OPTIONAL}
DESTINATION ${CMAKE_INSTALL_LIBDIR})
string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
string(PREPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
list(INSERT ARROW_STATIC_INSTALL_INTERFACE_LIBS 0 "Arrow::arrow_bundled_dependencies")
endif()

Expand Down

0 comments on commit eb5de18

Please sign in to comment.