GH-38861: [C++] Add missing "-framework Security" to Libs.private in arrow.pc

[kou]

Rationale for this change

It's required only when:

• We use bundled aws-sdk-cpp.
• We use static library for Apache Arrow C++.

Because bundled aws-sdk-cpp uses Security framework.

What changes are included in this PR?

Add -framework Security to Libs.private only on the condition.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

• Closes: [C++] Static pkg-config file needs -framework Security on MacOS #38861

[github-actions]

⚠️ GitHub issue #38861 has been automatically assigned in GitHub to PR creator.

[kou]

@github-actions crossbow submit r-binary-packages

[kou]

@github-actions crossbow submit r-binary-packages

[github-actions]

Revision: 8b50d33

Submitted crossbow builds: ursacomputing/crossbow @ actions-9680384154

Task	Status
r-binary-packages

[kou]

@jeroen Could you try this? You can download binaries from https://github.com/ursacomputing/crossbow/actions/runs/6971635888#artifacts .
I think that r-lib__libarrow__bin__darwin-x86_64-openssl-1.1 will have binaries for your case.

[jeroen]

Thanks, lgtm

[kou]

@github-actions crossbow submit -g cpp

[kou]

Thanks for confirming this.
I'll merge this after we confirm that additional CI jobs are also passed.

[github-actions]

Revision: 8b50d33

Submitted crossbow builds: ursacomputing/crossbow @ actions-ef38e34475

Task	Status
test-alpine-linux-cpp
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-cuda-cpp
test-debian-11-cpp-amd64
test-debian-11-cpp-i386
test-fedora-38-cpp
test-ubuntu-20.04-cpp
test-ubuntu-20.04-cpp-bundled
test-ubuntu-20.04-cpp-minimal-with-formats
test-ubuntu-20.04-cpp-thread-sanitizer
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-20
test-ubuntu-22.04-cpp-no-threading

[assignUser]

test-conda-cpp-valgrind has been failing for a month so not relevant here. 👍

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit eb5de18.

There were 2 benchmark results indicating a performance regression:

• Commit Run on ursa-i9-9960x at 2023-11-25 05:30:14Z
  • tpch (R) with engine=arrow, format=parquet, language=R, memory_map=False, query_id=TPCH-15, scale_factor=1
  • tpch (R) with engine=arrow, format=native, language=R, memory_map=False, query_id=TPCH-18, scale_factor=1

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.