Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R] Map/list equality tests are failing only on the sanitizer nightlies #15001

Closed
paleolimbot opened this issue Dec 16, 2022 · 3 comments · Fixed by #15197
Closed

[R] Map/list equality tests are failing only on the sanitizer nightlies #15001

paleolimbot opened this issue Dec 16, 2022 · 3 comments · Fixed by #15197
Assignees
Milestone

Comments

@paleolimbot
Copy link
Member

Describe the bug, including details regarding any error messages, version, and platform.

I don't know why this is happening only on the sanitizer nightlies (test-ubuntu-18.04-r-sanitizer and test-fedora-r-clang-sanitizer) , but it seems to be the case.

These tests were added in #14847. @wjones127 any ideas?

Component(s)

R

@paleolimbot
Copy link
Member Author

This is also failing on the valgrind build: https://dev.azure.com/ursacomputing/crossbow/_build/results?buildId=42194&view=logs&j=0da5d1d9-276d-5173-c4c4-9d4d4ed14fdb&t=d9b15392-e4ce-5e4c-0c8c-b69645229181&l=27730

── Failure ('test-parquet.R:460'): Can read parquet with nested lists and maps ──
pq$a$type == list_of(list_of(list_of(utf8()))) is not TRUE

`actual`:   FALSE
`expected`: TRUE 
Backtrace:
    ▆
 1. └─arrow:::expect_equal(pq$a$type, list_of(list_of(list_of(utf8())))) at test-parquet.R:460:2
 2.   └─testthat::expect_true(...) at tests/testthat/helper-expectation.R:36:4
── Failure ('test-parquet.R:463'): Can read parquet with nested lists and maps ──
pq$a$type == map_of(utf8(), map_of(int32(), field("val", boolean(), nullable = FALSE))) is not TRUE

`actual`:   FALSE
`expected`: TRUE 
Backtrace:
    ▆
 1. └─arrow:::expect_equal(...) at test-parquet.R:463:2
 2.   └─testthat::expect_true(...) at tests/testthat/helper-expectation.R:36:4


@wjones127
Copy link
Member

This is failing for me locally as well now. expect_equal() is failing, but expect_true(pq$a$type$Equals(<expected type>)) is not.

@jonkeane
Copy link
Member

jonkeane commented Jan 4, 2023

I know what's going on here. I can send a PR unless you've already got it will?

jonkeane added a commit that referenced this issue Jan 5, 2023
* Closes: #15001

Lead-authored-by: Will Jones <willjones127@gmail.com>
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this issue Jan 5, 2023
* Closes: apache#15001

Lead-authored-by: Will Jones <willjones127@gmail.com>
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue Jan 9, 2023
* Closes: apache#15001

Lead-authored-by: Will Jones <willjones127@gmail.com>
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
Signed-off-by: Jonathan Keane <jkeane@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants