Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ruby] Specify -mmacox-version-min=10.14 explicitly for old Xcode #15134

Closed
kou opened this issue Dec 30, 2022 · 0 comments · Fixed by #15135
Closed

[Ruby] Specify -mmacox-version-min=10.14 explicitly for old Xcode #15134

kou opened this issue Dec 30, 2022 · 0 comments · Fixed by #15135
Assignees
@kou
Labels
Component: Ruby Type: enhancement
Milestone
11.0.0

Comments

@kou
Copy link
Member

kou commented Dec 30, 2022

Describe the enhancement requested

If we don't specify -mmacox-version-min=10.14, the following error is occurred:

/tmp/local/include/arrow/type.h:1745:36: error: 'get<arrow::FieldPath, arrow::FieldPath, std::string, std::vector<arrow::FieldRef>>' is unavailable: introduced in macOS 10.13
    if (IsFieldPath()) return std::get<FieldPath>(impl_).indices().size() > 1;
                                   ^

Component(s)

Ruby
kou added a commit to kou/arrow that referenced this issue Dec 30, 2022
@kou
apacheGH-15134: [Ruby] Specify -mmacox-version-min=10.14 explicitly f…
d4f939d 
…or old Xcode

This suppresses the following error with old Xcode:

    /tmp/local/include/arrow/type.h:1745:36: error:
    'get<arrow::FieldPath, arrow::FieldPath, std::string,
    std::vector<arrow::FieldRef>>' is unavailable: introduced in macOS
    10.13
        if (IsFieldPath()) return std::get<FieldPath>(impl_).indices().size() > 1;
                                       ^
@github-actions github-actions bot mentioned this issue Dec 30, 2022
Merged
kou added a commit that referenced this issue Dec 31, 2022
@kou
GH-15134: [Ruby] Specify -mmacox-version-min=10.14 explicitly for old…
3b566bf 
… Xcode (#15135)

This suppresses the following error with old Xcode:

    /tmp/local/include/arrow/type.h:1745:36: error:
    'get<arrow::FieldPath, arrow::FieldPath, std::string,
    std::vector<arrow::FieldRef>>' is unavailable: introduced in macOS
    10.13
        if (IsFieldPath()) return std::get<FieldPath>(impl_).indices().size() > 1;
                                       ^
* Closes: #15134

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 11.0.0 milestone Dec 31, 2022
EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this issue Jan 5, 2023
@kou @EpsilonPrime
apacheGH-15134: [Ruby] Specify -mmacox-version-min=10.14 explicitly f…
08cadea 
…or old Xcode (apache#15135)

This suppresses the following error with old Xcode:

    /tmp/local/include/arrow/type.h:1745:36: error:
    'get<arrow::FieldPath, arrow::FieldPath, std::string,
    std::vector<arrow::FieldRef>>' is unavailable: introduced in macOS
    10.13
        if (IsFieldPath()) return std::get<FieldPath>(impl_).indices().size() > 1;
                                       ^
* Closes: apache#15134

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this issue Jan 5, 2023
@kou @EpsilonPrime
apacheGH-15134: [Ruby] Specify -mmacox-version-min=10.14 explicitly f…
c931461 
…or old Xcode (apache#15135)

This suppresses the following error with old Xcode:

    /tmp/local/include/arrow/type.h:1745:36: error:
    'get<arrow::FieldPath, arrow::FieldPath, std::string,
    std::vector<arrow::FieldRef>>' is unavailable: introduced in macOS
    10.13
        if (IsFieldPath()) return std::get<FieldPath>(impl_).indices().size() > 1;
                                       ^
* Closes: apache#15134

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Ruby Type: enhancement
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-15134: [Ruby] Specify -mmacox-version-min=10.14 explicitly for old Xcode kou/arrow
1 participant
@kou