Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-15134: [Ruby] Specify -mmacox-version-min=10.14 explicitly for old Xcode #15135

Merged
merged 1 commit into from
Dec 31, 2022
Merged

GH-15134: [Ruby] Specify -mmacox-version-min=10.14 explicitly for old Xcode #15135

merged 1 commit into from
Dec 31, 2022

Conversation

kou
Copy link
Member

@kou kou commented Dec 30, 2022 •
edited by github-actions bot
Loading

This suppresses the following error with old Xcode:

/tmp/local/include/arrow/type.h:1745:36: error:
'get<arrow::FieldPath, arrow::FieldPath, std::string,
std::vector<arrow::FieldRef>>' is unavailable: introduced in macOS
10.13
    if (IsFieldPath()) return std::get<FieldPath>(impl_).indices().size() > 1;
                                   ^

@kou
apacheGH-15134: [Ruby] Specify -mmacox-version-min=10.14 explicitly f…
d4f939d 
…or old Xcode

This suppresses the following error with old Xcode:

    /tmp/local/include/arrow/type.h:1745:36: error:
    'get<arrow::FieldPath, arrow::FieldPath, std::string,
    std::vector<arrow::FieldRef>>' is unavailable: introduced in macOS
    10.13
        if (IsFieldPath()) return std::get<FieldPath>(impl_).indices().size() > 1;
                                       ^
@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #15134 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Dec 31, 2022

+1

@kou kou merged commit 3b566bf into apache:master Dec 31, 2022
@kou kou deleted the ruby-macosx-deployment-target branch December 31, 2022 21:16
@ursabot
Copy link

ursabot commented Jan 1, 2023

Benchmark runs are scheduled for baseline = 85db6f7 and contender = 3b566bf. 3b566bf is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️4.44% ⬆️1.67%] test-mac-arm
[Finished ⬇️2.55% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️2.86% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 3b566bfd ec2-t3-xlarge-us-east-2
[Failed] 3b566bfd test-mac-arm
[Finished] 3b566bfd ursa-i9-9960x
[Failed] 3b566bfd ursa-thinkcentre-m75q
[Finished] 85db6f7b ec2-t3-xlarge-us-east-2
[Failed] 85db6f7b test-mac-arm
[Finished] 85db6f7b ursa-i9-9960x
[Failed] 85db6f7b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Jan 1, 2023

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm
ursa-i9-9960x

EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this pull request Jan 5, 2023
@kou @EpsilonPrime
apacheGH-15134: [Ruby] Specify -mmacox-version-min=10.14 explicitly f…
08cadea 
…or old Xcode (apache#15135)

This suppresses the following error with old Xcode:

    /tmp/local/include/arrow/type.h:1745:36: error:
    'get<arrow::FieldPath, arrow::FieldPath, std::string,
    std::vector<arrow::FieldRef>>' is unavailable: introduced in macOS
    10.13
        if (IsFieldPath()) return std::get<FieldPath>(impl_).indices().size() > 1;
                                       ^
* Closes: apache#15134

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this pull request Jan 5, 2023
@kou @EpsilonPrime
apacheGH-15134: [Ruby] Specify -mmacox-version-min=10.14 explicitly f…
c931461 
…or old Xcode (apache#15135)

This suppresses the following error with old Xcode:

    /tmp/local/include/arrow/type.h:1745:36: error:
    'get<arrow::FieldPath, arrow::FieldPath, std::string,
    std::vector<arrow::FieldRef>>' is unavailable: introduced in macOS
    10.13
        if (IsFieldPath()) return std::get<FieldPath>(impl_).indices().size() > 1;
                                       ^
* Closes: apache#15134

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ruby] Specify -mmacox-version-min=10.14 explicitly for old Xcode
2 participants
@kou @ursabot