Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++][FlightRPC] DoAction cannot be fully streaming #15150

Closed
lidavidm opened this issue Jan 2, 2023 · 0 comments · Fixed by #15152
Closed

[C++][FlightRPC] DoAction cannot be fully streaming #15150

lidavidm opened this issue Jan 2, 2023 · 0 comments · Fixed by #15152

Comments

@lidavidm
Copy link
Member

lidavidm commented Jan 2, 2023

As noted by Kou, existing applications/tests may assume that DoAction is not actually a streaming call.

This might break wheel-macos-big-sur-*. For example: https://github.com/ursacomputing/crossbow/actions/runs/3815472986/jobs/6490471956#step:11:435

=================================== FAILURES ===================================
_________________________ test_none_action_side_effect _________________________

    def test_none_action_side_effect():
        """Ensure that actions are executed even when we don't consume iterator.
    
        See https://issues.apache.org/jira/browse/ARROW-14255
        """
    
        with ActionNoneFlightServer() as server, \
                FlightClient(('localhost', server.port)) as client:
            client.do_action(flight.Action("append", b""))
            r = client.do_action(flight.Action("get_value", b""))
>           assert json.loads(next(r).body.to_pybytes()) == [True]
E           assert [] == [True]
E             Right contains one more item: True
E             Full diff:
E             - [True]
E             + []

test-arm64-env/lib/python3.10/site-packages/pyarrow/tests/test_flight.py:2132: AssertionError
----------------------------- Captured stderr call -----------------------------
/Users/voltrondata/github-actions-runner/_work/crossbow/crossbow/arrow/cpp/src/arrow/status.cc:137: DoAction result was not fully consumed: Cancelled: Flight cancelled call, with message: CANCELLED. Detail: Cancelled

Originally posted by @kou in #15118 (comment)

@kou kou closed this as completed in #15152 Jan 3, 2023
kou pushed a commit that referenced this issue Jan 3, 2023
* Closes: #15150

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 11.0.0 milestone Jan 3, 2023
EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this issue Jan 5, 2023
…pache#15152)

* Closes: apache#15150

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this issue Jan 5, 2023
…pache#15152)

* Closes: apache#15150

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
vibhatha pushed a commit to vibhatha/arrow that referenced this issue Jan 9, 2023
…pache#15152)

* Closes: apache#15150

Authored-by: David Li <li.davidm96@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants