Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement for the documentation of Parquet reader #15185

Closed
LouisClt opened this issue Jan 4, 2023 · 0 comments · Fixed by #15184
Closed

Improvement for the documentation of Parquet reader #15185

LouisClt opened this issue Jan 4, 2023 · 0 comments · Fixed by #15184
Assignees
@LouisClt
Labels
Component: C++ Component: Documentation Component: Parquet Type: enhancement
Milestone
11.0.0

Comments

@LouisClt
Copy link
Contributor

LouisClt commented Jan 4, 2023

Describe the enhancement requested

Improve the comments so that it is clearer to which level the column_indexes refer to in the different reader methods.

Component(s)

C++, Documentation, Parquet
@github-actions github-actions bot mentioned this issue Jan 4, 2023
Merged
wjones127 added a commit that referenced this issue Jan 6, 2023
@LouisClt @wjones127
GH-15185: [C++][Parquet] Improve documentation for Parquet Reader col…
a580f27 
…umn_indices (#15184)

This aims to fix the documentation and improve it,, by better specifying to what level the column_indices given in argument refer to.
* Closes: #15185

Lead-authored-by: LouisClt <louis1110@hotmail.fr>
Co-authored-by: Will Jones <willjones127@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
@wjones127 wjones127 added this to the 11.0.0 milestone Jan 6, 2023
vibhatha pushed a commit to vibhatha/arrow that referenced this issue Jan 9, 2023
@LouisClt @wjones127 @vibhatha
apacheGH-15185: [C++][Parquet] Improve documentation for Parquet Read…
c91d28f 
…er column_indices (apache#15184)

This aims to fix the documentation and improve it,, by better specifying to what level the column_indices given in argument refer to.
* Closes: apache#15185

Lead-authored-by: LouisClt <louis1110@hotmail.fr>
Co-authored-by: Will Jones <willjones127@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this issue Jan 10, 2023
@LouisClt @wjones127 @EpsilonPrime
apacheGH-15185: [C++][Parquet] Improve documentation for Parquet Read…
dbc25a9 
…er column_indices (apache#15184)

This aims to fix the documentation and improve it,, by better specifying to what level the column_indices given in argument refer to.
* Closes: apache#15185

Lead-authored-by: LouisClt <louis1110@hotmail.fr>
Co-authored-by: Will Jones <willjones127@gmail.com>
Signed-off-by: Will Jones <willjones127@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LouisClt LouisClt

Labels
Component: C++ Component: Documentation Component: Parquet Type: enhancement
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-15185: [C++][Parquet] Improve documentation for Parquet Reader column_indices LouisClt/arrow
4 participants
@rok @wjones127 @AlenkaF @LouisClt