-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] DenseUnionVector has no way to set offset/validity directly #24826
Comments
Liya Fan / @liyafan82: |
David Li / @lidavidm: The motivation here is we are constructing a dense union vector where the child arrays are in turn struct vectors. Semantically, this is intended as the union of distinct top-level schemas so that we can pass through different datasets in a single Flight RPC. Ideally we can do this with minimal/no copying or allocation, so being able to just transfer the arrays from the input VectorSchemaRoots and construct the right type ID and offset buffers is perfect. |
Bryan Cutler / @BryanCutler: |
@lidavidm We've found setOffset to be useful here when constructing DUVs by adding values directly to the underlying vectors - i.e. we do We've got a commit for it here - would it be something we could donate upstream? (We've got plenty of end-to-end tests covering it in XTDB, but would also add some unit tests if we raised a PR here.) |
Sure, I think it makes sense to have still. |
### Are these changes tested? Yes ### Are there any user-facing changes? Yes - the addition of a public DUV.setOffset method * GitHub Issue: #24826 Authored-by: James Henderson <james@jarohen.dev> Signed-off-by: David Li <li.davidm96@gmail.com>
Issue resolved by pull request 40985 |
### Are these changes tested? Yes ### Are there any user-facing changes? Yes - the addition of a public DUV.setOffset method * GitHub Issue: apache#24826 Authored-by: James Henderson <james@jarohen.dev> Signed-off-by: David Li <li.davidm96@gmail.com>
### Are these changes tested? Yes ### Are there any user-facing changes? Yes - the addition of a public DUV.setOffset method * GitHub Issue: apache#24826 Authored-by: James Henderson <james@jarohen.dev> Signed-off-by: David Li <li.davidm96@gmail.com>
You can set the type ID manually, but you cannot set the offset or validity directly. Ideally, we'd have an API like Python that lets us build it directly from constituent vectors and the offsets/type IDs.
Reporter: David Li / @lidavidm
Note: This issue was originally created as ARROW-8666. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: