Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Use of target_include_directories on imported targets requires cmake >= 3.11 #26394

Closed
assignUser opened this issue Jan 10, 2023 · 3 comments · Fixed by #33606
Closed

[Python] Use of target_include_directories on imported targets requires cmake >= 3.11 #26394

assignUser opened this issue Jan 10, 2023 · 3 comments · Fixed by #33606
Assignees
@kou
Labels
Component: Python Type: bug
Milestone
11.0.0

Comments

@assignUser
Copy link
Member

assignUser commented Jan 10, 2023 •
edited
Loading

Describe the bug, including details regarding any error messages, version, and platform.

https://github.com/ursacomputing/crossbow/actions/runs/3829615557/jobs/6516509884#step:5:12900

Introduced by #15143

Component(s)

Python
@assignUser
Copy link
Member Author

@kou I would be in favour of bumping the required cmake version vs adding in a (likely ugly) workaround as 3.11 should be no problem for manylinux

@assignUser assignUser changed the title [Python] Use of target_include_directories requires cmake >= 3.11 [Python] Use of target_include_directories on imported targets requires cmake >= 3.11 Jan 10, 2023
@kou
Copy link
Member

kou commented Jan 10, 2023

Sorry. I didn't notice it.
We can bump required CMake version to 3.16 since Apache Arrow 12.0.0 or 13.0.0 because Ubuntu 18.04 will reach EOL on 2023-04.
I'll add a workaround for 3.11 for now.

@assignUser
Copy link
Member Author

Great, I am very much looking forward to 3.16, will allow us to use FetchContent and other goodies :D

kou added a commit to kou/arrow that referenced this issue Jan 11, 2023
@kou
apacheGH-26394: [Python] Don't use target_include_directories() for i…
851e235 
…mported target

It requires CMake 3.11 or later.
@kou kou mentioned this issue Jan 11, 2023
Merged
kou added a commit that referenced this issue Jan 12, 2023
@kou
GH-26394: [Python] Don't use target_include_directories() for importe…
2e3683b 
…d target (#33606)

# Which issue does this PR close?

Closes #26394

# Rationale for this change

We require at least CMake 3.5 for now.

# What changes are included in this PR?

Add workaround for CMake < 3.11.

# Are these changes tested?

Yes.

# Are there any user-facing changes?

No.
* Closes: #26394

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 11.0.0 milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kou kou

Labels
Component: Python Type: bug
Projects
None yet
Milestone
11.0.0
Development

Successfully merging a pull request may close this issue.

GH-26394: [Python] Don't use target_include_directories() for imported target kou/arrow
2 participants
@kou @assignUser