-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MATLAB] Create arrow.Array class #27758
Comments
Todd Farmer / @toddfarmer: |
Marking this as resolved. An abstract Adding an architecture diagram (#28147) was initially included as a "sub-task" for this issue in Jira. We should still add architecture diagrams for the MATLAB Interface, but we can track that separately so that we can close out this old issue (which is effectively complete because the base I've removed #28147 from the list of sub-tasks in the description of this issue. |
…de (#37204) ### Rationale for this change Now that `featherread` and `featherwrite` have been re-implemented in terms of the new MATLAB Interface APIs (#37163 and #37047), we can remove the unused feather V1 MEX infrastructure and code. ### What changes are included in this PR? 1. Deleted the following source and header files that are specific to the feather V1 MEX implementation: - `arrow/matlab/src/cpp/arrow/matlab/feather/feather_functions.[cc][h]` - `arrow/matlab/src/cpp/arrow/matlab/feather/feather_reader.[cc][h]` - `arrow/matlab/src/cpp/arrow/matlab/feather/feather_writer.[cc][h]` - `arrow/matlab/src/cpp/arrow/matlab/feather/matlab_traits.h` - `arrow/matlab/src/cpp/arrow/matlab/feather/util/handle_status.[cc][h]` - `arrow/matlab/src/cpp/arrow/matlab/feather/util/unicode_conversion.[cc][h]` - `arrow/matlab/src/cpp/arrow/matlab/mex/call.cc` - `arrow/matlab/src/cpp/arrow/matlab/mex/mex_functions.h` - `arrow/matlab/src/cpp/arrow/matlab/mex/mex_util.[cc][h]` - `arrow/matlab/src/cpp/arrow/matlab/mex/mex_util_test.cc` - `arrow/matlab/src/cpp/arrow/matlab/api/visibility.h` 2. Deleted the following feather V1 MEX-specific build infrastructure files: - `arrow/matlab/build_support/common_vars.m` - `arrow/matlab/build_support/compile.m` - `arrow/matlab/build_support/test.m` 3. Removed all feather V1 MEX-specific logic from the `arrow/matlab/CMakeLists.txt` file. ### Are these changes tested? No tests are needed. The old feather V1 MEX specific implementation is unused code. ### Are there any user-facing changes? No. ### Future Directions 1. Review the back-log of stale tasks/issues that are no longer actionable and close them. For example, #27758 has already been implemented and submitted with a different issue attached. * Closes: #37203 Lead-authored-by: Sarah Gilmore <sgilmore@mathworks.com> Co-authored-by: Kevin Gurney <kgurney@mathworks.com> Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
…and code (apache#37204) ### Rationale for this change Now that `featherread` and `featherwrite` have been re-implemented in terms of the new MATLAB Interface APIs (apache#37163 and apache#37047), we can remove the unused feather V1 MEX infrastructure and code. ### What changes are included in this PR? 1. Deleted the following source and header files that are specific to the feather V1 MEX implementation: - `arrow/matlab/src/cpp/arrow/matlab/feather/feather_functions.[cc][h]` - `arrow/matlab/src/cpp/arrow/matlab/feather/feather_reader.[cc][h]` - `arrow/matlab/src/cpp/arrow/matlab/feather/feather_writer.[cc][h]` - `arrow/matlab/src/cpp/arrow/matlab/feather/matlab_traits.h` - `arrow/matlab/src/cpp/arrow/matlab/feather/util/handle_status.[cc][h]` - `arrow/matlab/src/cpp/arrow/matlab/feather/util/unicode_conversion.[cc][h]` - `arrow/matlab/src/cpp/arrow/matlab/mex/call.cc` - `arrow/matlab/src/cpp/arrow/matlab/mex/mex_functions.h` - `arrow/matlab/src/cpp/arrow/matlab/mex/mex_util.[cc][h]` - `arrow/matlab/src/cpp/arrow/matlab/mex/mex_util_test.cc` - `arrow/matlab/src/cpp/arrow/matlab/api/visibility.h` 2. Deleted the following feather V1 MEX-specific build infrastructure files: - `arrow/matlab/build_support/common_vars.m` - `arrow/matlab/build_support/compile.m` - `arrow/matlab/build_support/test.m` 3. Removed all feather V1 MEX-specific logic from the `arrow/matlab/CMakeLists.txt` file. ### Are these changes tested? No tests are needed. The old feather V1 MEX specific implementation is unused code. ### Are there any user-facing changes? No. ### Future Directions 1. Review the back-log of stale tasks/issues that are no longer actionable and close them. For example, apache#27758 has already been implemented and submitted with a different issue attached. * Closes: apache#37203 Lead-authored-by: Sarah Gilmore <sgilmore@mathworks.com> Co-authored-by: Kevin Gurney <kgurney@mathworks.com> Signed-off-by: Kevin Gurney <kgurney@mathworks.com>
Create arrow.Array, an abstract MATLAB class which represents arrow memory. Users can create an arrow.Array from MATLAB arrays. Concrete subclasses, such as arrow.UInt64Array or arrow.Float64Array, will allow the user to create specific array types. The design mirrors APIs of other language bindings in the Arrow project.
More details about the MATLAB Interface for Apache Arrow can be found here: https://github.com/mathworks/arrow/blob/ARROW-11795/matlab/doc/matlab_interface_for_apache_arrow_design.md
Reporter: Fiona La / @lafiona
Subtasks:
Note: This issue was originally created as ARROW-11919. Please see the migration documentation for further details.
The text was updated successfully, but these errors were encountered: